Skip to content

Update scala-library to 2.13.7 #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

scala-steward
Copy link
Contributor

Updates org.scala-lang:scala-library from 2.13.6 to 2.13.7.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-library" } ]

labels: library-update, early-semver-patch, semver-spec-patch

@SethTisue SethTisue self-assigned this Nov 2, 2021
@SethTisue
Copy link
Member

several errors of the form

[error] /home/runner/work/scala-collection-contrib/scala-collection-contrib/src/main/scala/scala/collection/MultiDict.scala:27:16: the type test for pattern scala.collection.MultiDict[K,V] cannot be checked at runtime because it has type parameters eliminated by erasure
22
[error]     case that: MultiDict[K, V] =>
23
[error]                ^

@SethTisue
Copy link
Member

offhand, without looking too hard, it appears to me that this is actually a progression in 2.13.7 — unchecked warnings weren't being issued when they should have been?

@joshlemer @julienrf might one of you be interested in digging into this?

we could certainly just make it compile by slapping @unchecked on the matches, but ought we to do better here?

@SethTisue SethTisue removed their assignment Nov 2, 2021
@SethTisue
Copy link
Member

SethTisue commented Nov 2, 2021

scala/scala#9672 seems like a plausible reason for this to have progressed, cc @som-snytt

seeing if Scala 3 issues the same warnings would be a possible cross-check (and see also #119, a volunteer is still wanted to add a Scala 3 crossbuild)

@som-snytt
Copy link
Contributor

som-snytt commented Nov 2, 2021

Yes, I remember Lukas improved some K, V kraziness when it went over my head.

Is this even korrekt?

sets forall { case (k, vs) => that.sets.get(k).contains(vs) }

where sets is def sets: Map[K, Set[V]]. It looks like it's asking if a set contains a set. contains won't tell us if we got it wrong, even if the K, V align.

EDIT: that is Map.get and Option.contains, duh.

@som-snytt
Copy link
Contributor

I see in the linked PR that we sprinkled unchecked in these cases. Not sure if we suffered much over whether the code was actually correct. I will PR that here if it helps more than hurts.

@som-snytt
Copy link
Contributor

som-snytt commented Nov 2, 2021

oh, it goes on:

MultiDict.scala:107:40: method toIterable in trait IterableOps is deprecated (since 2.13.7): toIterable is internal and will be made protected; its name is similar to `toList` or `toSeq`, but it doesn't copy non-immutable collections

I think I PR'd the compiler option to limp thru RefChecks in the face of errors, and this is why.

Also -Wconf isn't making it stop. Maybe it continues to warn only for js? Let me find my sbt hat.

I couldn't get -Wconf but -nowarn works like a charm. I don't know why people complain about tooling.

@som-snytt
Copy link
Contributor

Apparently scala module plugin interferes with setting -Wconf! Where do I complain?

@SethTisue
Copy link
Member

Apparently scala module plugin interferes with setting -Wconf! Where do I complain?

Sir, this is a Wendy's.

@som-snytt
Copy link
Contributor

som-snytt commented Nov 2, 2021

#157

I momentarily became an sbt hacker.

I'll make a follow-up PR to alias -Wconf as -Wendy.

@SethTisue
Copy link
Member

superseded by #157

@SethTisue SethTisue closed this Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants