Port to SBT 1.2.8, sbt-scala-module, and Scala 2.13.0 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
reviewed
Jul 1, 2019
| @@ -1,11 +1,10 @@ | |||
| language: scala | |||
|
|
|||
| jdk: | |||
| - oraclejdk8 | |||
There was a problem hiding this comment.
Why remove that jdk version? In the build.sbt file you tell sbt to use jdk 8 for publishing, so we should keep that version. You can use openjdk8 instead of oraclejdk8, if there is any issue with the latter.
There was a problem hiding this comment.
Thanks, that seems to have worked
julienrf
approved these changes
Jul 1, 2019
|
I just realized that the commit message is a bit sloppy. If necessary I can reword it and push the commit again. |
|
Can someone from the org.scala-lang organization approve or dismiss this PR? I think that in order to effectively publish releases we also need to provide secrets (sonatype credentials) to the Travis CI. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and adapted the project as far as I was able to. I'm not very familiar with SBT, so I am afraid that this PR is 60% cargo cult. It might be helpful anyway. I will be happy to make adjustments as necessary if someone guides me a bit.
Fixes #3