Skip to content

Commit 28526d3

Browse files
authored
edits to Scala release steps (#804)
* lengthen the testing period after a release candidate is chosen * lengthen the wait time between publishing and announcing * release on GitHub at announement time, not publishing time * add steps for downstream projects such as Scala.js, SDKMAN, Scala Steward, Scalameta, kind-projector, genjavadoc, ... * require signoff from the Scala Center and VirtusLab fixes #799
1 parent cb1e492 commit 28526d3

File tree

1 file changed

+73
-37
lines changed

1 file changed

+73
-37
lines changed

.github/ISSUE_TEMPLATE/release.md

+73-37
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
---
22
name: Release
33
about: Tracking issue for a release
4-
title: Release 2.y.z
4+
title: Release Scala 2
55
---
6-
For every Scala release, make a copy of this file named after the release, and expand the variables.
7-
Ideally this should become a script you can run on your local machine. The only missing piece is programmatic triggering of Travis-CI jobs with custom config.
86

9-
Variables to be expanded in this template (or export them in a local terminal, so that you can copy/paste the commands below without replacing anything):
7+
Use this template to make a scala-dev ticket named after the release, and fill in the variables.
8+
9+
Variables to be expanded in this template (or set and export them in a local terminal, so that you can copy/paste the commands below without replacing anything):
1010

1111
```bash
1212
SCALA_VER_BASE="2.13.0"
13-
SCALA_VER_SUFFIX="-M5"
13+
SCALA_VER_SUFFIX=""
1414
SCALA_SHA=????????????????????????????????????????
1515
DIST_SHA=????????????????????????????????????????
1616
SCALA_VER="$SCALA_VER_BASE$SCALA_VER_SUFFIX"
@@ -24,6 +24,7 @@ Key links:
2424
- release notes draft: https://github.com/scala/scala-dev/blob/scala-dev/releases/2.13.?.md
2525

2626
### N weeks before the release
27+
2728
- [ ] Wind down PR queue. There has to be enough time after the last (non-trivial) PR is merged and the next phase. The core of the eco-system needs time to prepare for the final!
2829
- [ ] Triage scala/bug and scala/scala-dev tickets
2930
- [ ] Create next scala/scala milestone, move the magical "Merge to 2.13.x" description to it (so Scabot uses it as default for new PRs), move pending PRs
@@ -34,6 +35,7 @@ Key links:
3435
- [ ] Also notify Scala Center advisory board members of the upcoming release, so they can help test if they want (Seth can handle this, if asked)
3536

3637
### Release announcement / notes
38+
3739
- [ ] Notify community on https://contributors.scala-lang.org/c/announcements
3840
- [ ] Review merged PRs, make sure release-notes label is applied appropriately
3941
- [ ] PRs with release-notes label must have excellent title & description (title will be pasted literally in release note bullet list)
@@ -42,6 +44,7 @@ Key links:
4244
- [ ] On contributors thread, link to release note file and request feedback
4345

4446
### N days before release
47+
4548
- [ ] Announce no more PRs will be merged unless last-minute regressions are found. Re-iterate current nightly sha version for testing.
4649
- [ ] Community build
4750
- JDK 8: https://scala-ci.typesafe.com/job/scala-2.13.x-jdk8-integrate-community-build/????
@@ -53,21 +56,21 @@ Key links:
5356
- [ ] Merge in any older release branch
5457
- [ ] Check module versioning (is everything in versions.properties up to date?)
5558
- including make sure the version of [scala-asm][] we're using is using latest [ASM][]
56-
- [ ] On major release, bump PickleFormat version
59+
- ~On major release, bump PickleFormat version~
5760
- [ ] Close the scala/scala and scala/bug milestones
5861

5962
[scala-asm]: https://github.com/scala/scala-asm/
6063
[ASM]: https://asm.ow2.io/versions.html
6164

6265
### Point of no return
6366

64-
Once sufficient time has passed since last merged PR, it's time to cut the release!
67+
Once sufficient time for community testing has passed, it's time to cut the release!
6568

66-
How long we wait depends on what kind of release it is. For a major release, it might be 1-2 weeks, to give core projects time to try out the preceding release candidate and/or the current candidate nightly. For point releases, assuming we've given the community ahead-of-time warning and kept them appraised of progress on the Discourse thread, and assuming the last changes merged seem sufficiently safe, we might build the next day.
69+
What is "sufficient" time? A week is a bare minimum. Two weeks is a better "normal" amount. We should also respect requests from Scala Center advisory board members, if they explicitly ask for additional testing time. (In the past, we sometimes only waited a day or two, but this was overly optimistic in presuming that people had been testing nightlies all along.)
6770

68-
Be mindful of others' schedules; even minor releases make work downstream (for Scala.js and Scala Native, for the Scala 3 team, for compiler plugin authors, and so on). It's better not to release on Friday or before a holiday.
71+
Be mindful of others' schedules; even minor releases make work downstream (for Scala.js and Scala Native, for the Scala 3 team, for compiler plugin authors, and so on). And a botched release might make unexpected work for ourselves as well as for others. So it's better not to release on a Friday or even a Thursday, or too close to a major holiday. And it's best to release while everyone in both America and Europe is awake. (First thing in the morning in America is a good choice.)
6972

70-
- [ ] Make sure there are no stray [staging repos](https://oss.sonatype.org/#stagingRepositories) on sonatype
73+
- [ ] Make sure there are no stray [staging repos](https://oss.sonatype.org/#stagingRepositories) on Sonatype
7174
- [ ] Trigger a custom build on [travis](https://app.travis-ci.com/github/scala/scala)
7275
- Select the correct branch
7376
- Custom config: `before_script: export SCALA_VER_BASE=$SCALA_VER_BASE SCALA_VER_SUFFIX=$SCALA_VER_SUFFIX`
@@ -84,28 +87,29 @@ Be mindful of others' schedules; even minor releases make work downstream (for S
8487
- [ ] Check that JARs haven't mysteriously bloated — compare sizes to previous release. We have no other backstop for this.
8588
- Remember, tags are forever, so are maven artifacts (even staged ones, as they could end up in local caches) and S3 uploads (S3 buckets can be changed, but it can takes days to become consistent)
8689
- [ ] Push scala/scala tag: `git push https://github.com/scala/scala.git v$SCALA_VER`
87-
- [ ] Add release notes to https://github.com/scala/scala/releases/tag/v$SCALA_VER
90+
- [ ] Add release notes to https://github.com/scala/scala/releases/tag/v$SCALA_VER but leave the release as draft for now
8891
- [ ] Push scala/scala-dist tag: `git push https://github.com/scala/scala-dist.git v$SCALA_VER`
8992
- [ ] Trigger two scala-dist jobs on travis (https://app.travis-ci.com/github/scala/scala-dist) with custom config. must use full-length SHAs!
9093
- `before_script: export version=$SCALA_VER scala_sha=$SCALA_SHA mode=archives`: https://app.travis-ci.com/github/scala/scala-dist/builds/?
9194
- `before_script: export version=$SCALA_VER scala_sha=$SCALA_SHA mode=update-api`: https://app.travis-ci.com/github/scala/scala-dist/builds/?
9295
- [ ] Promote staging repos: `st_stagingRepoPromote [scala-repo]`, `st_stagingRepoPromote [modules-repo]` (or use oss.sonatype.org web UI)
9396

9497
### Check availability
98+
9599
- [ ] Check release on sonatype: https://oss.sonatype.org/content/repositories/releases/org/scala-lang/scala-compiler/$SCALA_VER/
96100
- [ ] Check the release on maven central: https://repo1.maven.org/maven2/org/scala-lang/scala-compiler/$SCALA_VER/
97101

98102
### When everything is on maven central
103+
99104
- [ ] Prepare PR to https://github.com/scala/scala-lang/ (using scala/make-release-notes which requires a staged release and a pushed tag)
100105
- `download/index.md`
101106
- `_config.yml` (update devscalaversion or scalaversion)
102107
- `index.md` (update `currentScalaVersion`)
103108
- [ ] Prepare PR to https://github.com/scala/docs.scala-lang/
104109
- `api/all.md`, `_config.yml`, `_overviews/jdk-compatibility/overview.md`
105-
- [ ] make sure the draft release notes are on GitHub tag: https://github.com/scala/scala/releases/tag/v$SCALA_VER
106110
- [ ] Pre-announce the release on https://contributors.scala-lang.org/c/announcements
107-
- [ ] On 2.13.0 only: (manually) update the `current` symlink for the API docs
108-
- https://github.com/scala/scala-dist/blob/2.13.x/scripts/jobs/release/website/update-api#L15
111+
- [ ] ~On major releases only: (manually) update the `current` symlink for the API docs~
112+
- ~https://github.com/scala/scala-dist/blob/2.13.x/scripts/jobs/release/website/update-api#L15~
109113
- [ ] Check that the API docs are published
110114
- https://www.scala-lang.org/api/$SCALA_VER/
111115
- https://docs.scala-lang.org/api/all.html ?
@@ -117,43 +121,75 @@ Be mindful of others' schedules; even minor releases make work downstream (for S
117121
- if you don't have the credential for this locally but you are able to bring jenkins-worker-publish up at `ssh jenkins-worker-publish`, then from there you can `ssh -i ~/.ssh/jenkins_lightbend_chara [email protected]`
118122
- see if https://scala-webapps.epfl.ch/jenkins/view/All/job/production_scala-lang.org-scala-dist-archive-sync/ has run a job yet to sync the changes into production
119123
- if not, you can manually trigger a job. Seth has access to do that, probably others on the team do too. if we get stuck, Fabien can help
120-
- [ ] Merge the scala-lang PR and the docs.scala-lang.org PR
121-
- [ ] wait for them to arrive on the websites and make sure they look okay
122-
- if the scala-lang changes don't show up, possible troubleshooting steps include:
123-
- see if https://scala-webapps.epfl.ch/jenkins/view/All/job/production_scala-lang.org-builder/ has run a job yet to actually publish the changes
124-
- see note above about permissions to trigger a job
125124

126-
### Modules
125+
### Prepare downstream
126+
127+
- [ ] Create PR to add/update spec links on scala-lang.org (example: https://github.com/scala/scala-lang/pull/1050)
127128
- [ ] build and release scala-collection-compat and other modules (or open tickets asking that the maintainers do so)
128129
- this work has moved to https://github.com/scala/make-release-notes/blob/2.13.x/projects-2.13.md
129130
- [ ] if it's a 2.12.x release, publish macro paradise for the new version
131+
- [ ] Open a [typelevel/kind-projector](https://github.com/typelevel/kind-projector/issues) ticket requesting publishing
132+
- [ ] (Lightbend) Open a [lightbend/genjavadoc](https://github.com/lightbend/genjavadoc/issues) ticket requesting publishing (the Akka team usually does it)
133+
- [ ] Consider updating https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html
134+
135+
### Wait for downstream
136+
137+
Before proceeding any further, wait for the ecosystem to catch up.
138+
139+
- Downstream publishing:
140+
- [ ] Wait for Scala.js to support the new release
141+
- [ ] Wait for scalameta and scalameta-based tooling such as Metals to publish
142+
- [ ] Wait for kind-projector to publish
143+
- [ ] Wait for scoverage to publish
144+
- Downstream signoffs:
145+
- [ ] Wait for the Scala Center to sign off (Seb)
146+
- [ ] Wait for VirtusLab to sign off (Krzysztof)
147+
148+
We have promised to wait **48 non-weekend hours**, minimum.
149+
150+
If there are delays downstream, at some point it may make sense to go
151+
ahead and announce anyway, since news of the release will already be
152+
spreading in the community.
130153

131154
### Announcements
155+
156+
- [ ] on GitHub, change the release from "draft" to "release":
157+
- https://github.com/scala/scala/releases/tag/v$SCALA_VER
158+
- [ ] Merge the scala-lang PR and the docs.scala-lang.org PR
159+
- [ ] wait for them to arrive on the websites and make sure they look okay
160+
- if the scala-lang changes don't show up, possible troubleshooting steps include:
161+
- see if https://scala-webapps.epfl.ch/jenkins/view/All/job/production_scala-lang.org-builder/ has run a job yet to actually publish the changes
162+
- see note above about permissions to trigger a job
132163
- [ ] Scala Users discourse https://users.scala-lang.org
133-
- [ ] add a reply on the same https://contributors.scala-lang.org thread where you announced that the release process was starting
134164
- [ ] Tweet from [@scala_lang](https://twitter.com/scala_lang)
135-
- [ ] https://gitter.im/scala/scala
136-
- [ ] if you feel like it, say something in https://gitter.im/scala/contributors too
137-
- [ ] Discord in addition, or instead?
165+
- [ ] Discord: link to release notes in #announcements channel
166+
- [ ] consider also saying something in #scala-contributors channel
167+
- [ ] Unblock the release in Scala Steward by PRing an update to [default.scala-steward.conf](https://github.com/scala-steward-org/scala-steward/blob/master/modules/core/src/main/resources/default.scala-steward.conf)
168+
- [ ] Ensure SDKMAN makes the release available (see scala/scala-dev#782)
138169
- [ ] ask Seth to announce on #scala IRC
139170

140171
### Afterwards
141-
- [ ] Check the release on maven search (may take a few hours):
142-
- https://search.maven.org/search?q=g:org.scala-lang%20AND%20v:$SCALA_VER
143-
- [ ] Create PR to add/update spec links on scala-lang.org (example: https://github.com/scala/scala-lang/pull/1050)
172+
173+
- [ ] Scastie: open PR adding new version (modeled on https://github.com/scalacenter/scastie/pull/538)
174+
- note that the PR won't be mergeable until kind-projector has published; and if kind-projector's version number has changed, `ScalaTarget.scala` will need updating
175+
- ~If it's a major release:~
176+
- ~Update `latestSpecVersion` in `spec/_config.yml` on the old branch, so that spec is marked as no longer current~
177+
- ~Ditto for the nightly build and spec links in `_data/footer.yml` and `_data/doc-nav-header.yml` on docs.scala-lang.org~
178+
- [ ] Create PR to update https://github.com/lightbend/lightbend-technology-intro-doc/blob/master/docs/modules/getting-help/pages/build-dependencies.adoc
179+
- (Lightbend) Fortify:
180+
- [ ] Publish scala-fortify-plugin
181+
- [ ] Update scala-fortify
182+
- [ ] Update scala-fortify-docs
183+
- [ ] (Lightbend) Update whatever we replaced WhiteSource with, if anything?
184+
- [ ] (Lightbend) Notify eng-updates
185+
- [ ] Update https://contributors.scala-lang.org thread
144186
- [ ] Create a scala/scala PR to:
145187
- [ ] update `starr.version` in `/versions.properties`
146188
- [ ] update `Global / baseVersion` in `/build.sbt`
147189
- [ ] update `mimaReferenceVersion` in `/project/MimaFilters.scala`
148190
- [ ] clear out `mimaFilters` in `/project/MimaFilters.scala`, except the one(s) labeled "KEEP"
149-
- [ ] `spec/_config.yml`, if it's a major bump
150-
- If it's a major bump:
151-
- [ ] Update `latestSpecVersion` in `spec/_config.yml` on the old branch, so that spec is marked as no longer current
152-
- [ ] Ditto for the nightly build and spec links in `_data/footer.yml` and `_data/doc-nav-header.yml` on docs.scala-lang.org
153-
- [ ] Create PR to update https://github.com/lightbend/lightbend-technology-intro-doc/blob/master/docs/modules/getting-help/pages/build-dependencies.adoc
154-
- [ ] Consider updating https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html
155-
- [ ] (Lightbend) Publish scala-fortify-plugin
156-
- [ ] (Lightbend) Update whatever we replaced WhiteSource with?
157-
- [ ] (Lightbend) Notify eng-updates
158-
- [ ] Scastie: open PR adding new version (modeled on https://github.com/scalacenter/scastie/pull/538)
191+
- ~`spec/_config.yml`, if it's a major release~
192+
193+
### You're done!
194+
159195
- [ ] Close this ticket and close the scala-dev milestone

0 commit comments

Comments
 (0)