-
Notifications
You must be signed in to change notification settings - Fork 14
Get our test suite working on Java 11 and 16 #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
✋ |
I finally got started on this. I needed an excuse to use Java 10... |
should be very easy in Travis-CI. would be harder in Jenkins. |
|
@som-snytt can't hear you, too busy watching “Good Times” re-runs |
I've fixed the OSGi tests in scala/scala#6937 After scala/scala#6889, I'm down to two failed partests:
As well as:
|
I was eager to understand the bench fails but had a busy weekend. It wasn't immediately obvious if it was an sbt-jmh versioning or what. I saw some classpath manipulation in the plugin, but got time boxed. |
I lost an edit to the to comment above. The compilation of For the |
In Sorry about that @retronym scala/scala#6939 Also FWIW:
|
(I've changed the ticket title since JDK 9 and 10 are now history) |
@diesalbla here's the umbrella ticket on this, re your recent PR scala/scala#8331 some (all?) of Som's fixes so far are in scala/scala#6889 . |
I do still intend to add 11 and perhaps 15 to our CI — I'm tasked with it (@lrytz agrees it's needed), but it hasn't made it to the top of my queue. I hope to get to it this year. |
I'm a bit concerned that just straight up adding 11 to the matrix would make PR validation slower. Maybe a nightly run? |
So, with Travis CI in a better state where it can run on forks (by having testAll1 and testAll2 parallel jobs) I think we could benefit from fixing up the remaining JDK 11 issues (mostly on 2.12.x) and enforcing they stay fixed by running a nightly Travis CI cron job - and setting that up would be easy for me. So I'll try. |
Running
|
The unit tests I guess are flaky and/or cross-talk? Can't repro. The partests and MiMa I've looked to address with scala/scala#9323. |
@dwijnand Probably you're on Windows? I get the following on first run. I'll double check.
|
No, I'm on macOS. So my first failure was running |
fixed by #559 thx @som-snytt and everyone else who helped chip away at this over the years |
Here's the current state of running our test suite of Java 9:
https://gist.github.com/retronym/65527edfa7dcb4a4e905f364db9788d3
That's based on sbt testAll on the tip of scala/scala#6733.
I expect the majority of failures will just requires some changes to the test themselves.
Getting these working will let us include Java 9/10 in our CI.
The text was updated successfully, but these errors were encountered: