Skip to content

install nodejs/npm on workers #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2016

Conversation

SethTisue
Copy link
Member

for Scala.js. requested by @sjrd at scala/community-build#276

@SethTisue
Copy link
Member Author

I provisionally deployed this. here's what we see now on the workers:

ubuntu@ip-172-31-12-38:~$ nodejs --version
v4.2.6
ubuntu@ip-172-31-12-38:~$ node --version
The program 'node' is currently not installed. You can install it by typing:
sudo apt install nodejs-legacy
ubuntu@ip-172-31-12-38:~$ npm --version
The program 'npm' is currently not installed. You can install it by typing:
sudo apt install npm

the node version seems a bit old

@SethTisue
Copy link
Member Author

the Chef cookbook we're using supports different installation methods. the default method is to use apt, and I checked that sudo apt-get update followed by apt list --upgradable doesn't show a newer version, so I guess that's just what the version of Ubuntu we're using offers?

@sjrd is it sufficient?

@SethTisue SethTisue self-assigned this Sep 15, 2016
@SethTisue
Copy link
Member Author

also does nodejs vs node matter?

trying a new test run at https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-community-build/300/console

@sjrd
Copy link
Member

sjrd commented Sep 15, 2016

Yes, nodejs vs node matters. By default, Scala.js looks for node, but the nodejs thing is a known issue for Ubuntu, for which we have a workaround: add jsEnv := NodeJSEnv(executable = "nodejs").value in the settings of projects that need to run with Node.js. I'll update the PR on community-builds.

@SethTisue
Copy link
Member Author

merged since latest community build runs are green.

but @adriaanm, you might want to give the Chef changes a once-over and make sure I didn't cargo-cult in some nonsense

@SethTisue SethTisue deleted the be-webscale-install-nodejs branch September 20, 2016 05:26
@adriaanm
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants