-
Notifications
You must be signed in to change notification settings - Fork 131
Fix js/native support & bump sbt and plugins versions #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sbt-crossproject already handles that, but naming them by hand changed the name of the produced artifacts (`scala-parser-combinators-js_sjs0.6_2.12-...`).
10bb3c3
to
7ceb1c1
Compare
Upgrading scala-js to 0.6.20 breaks the build (because of scala-js/scala-js/issues/3128), so only 0.6.19. |
7ceb1c1
to
18e1a75
Compare
I triggered a test build here, but the automated publishing didn't do the right thing: That build matrix is becoming really ugly... 😞 |
@gourlaysama it seems we have the same issue with scala-js. Another issue with the current setup: the build runs I need to come up with a cross versioning scheme that also supports js / native. |
FTR i have some WIP here: https://github.com/lrytz/sbt-scala-module/tree/platforms. Not yet working; I would basically like to completely disable / remove a project (js / native) if its It also needs sbt-doge (or sbt 1). |
It seems to me that we both could and should just drop sbt 0.13 support. |
Naming the js/native projects by hand changed the produced artifactIds
(
scala-parser-combinators-js_sjs0.6_2.12
), and that breaks dependency resolution.And then we can release 1.0.7! 🎉