Cross compile with the new collections #134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
commented
Jan 19, 2018
| @@ -0,0 +1 @@ | |||
| ../../../../../scala-2.12/scala/util/parsing/input/PagedSeq.scala | |||
There was a problem hiding this comment.
I moved PagedSeq.scala to the src/main/scala-2.12 source directory and symlinked it from here (scala-2.11 source directory)
There was a problem hiding this comment.
This probably doesn't work on Windows. Alternatively we can do something like sbt/sbt#2310
julienrf
commented
Jan 19, 2018
|
|
||
| // Members declared in scala.collection.IterableOps | ||
| protected[this] def fromSpecificIterable(coll: collection.Iterable[T]): collection.IndexedSeq[T] = iterableFactory.from(coll) | ||
| protected[this] def newSpecificBuilder(): collection.mutable.Builder[T, collection.IndexedSeq[T]] = iterableFactory.newBuilder() |
There was a problem hiding this comment.
The only difference with the 2.11 and 2.12 implementation is these 3 lines above that have been added.
There was a problem hiding this comment.
What do you think about moving those methods to a separate trait in a separate source file? In versions up to 2.12 the source file trait would be empty. Then we can avoid duplicating the entire file.
julienrf
force-pushed
the
collection-strawman-bis
branch
from
784d2f3 to
d8512ba
Compare
Use distinct implementations of PagedSeq according to the scala version. Use JavaConverters rather than JavaConversions. Use ++= instead of copyToBuffer.
julienrf
force-pushed
the
collection-strawman-bis
branch
from
d8512ba to
bc39da6
Compare
|
is this superseded by #148? |
|
Yes, indeed. Sorry I forgot that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until 2.13 is released.