Skip to content

Update sbt to 1.3.0 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Update sbt to 1.3.0 #237

merged 2 commits into from
Sep 10, 2019

Conversation

scala-steward
Copy link
Contributor

Updates org.scala-sbt:sbt from 1.2.8 to 1.3.0.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: semver-minor

@SethTisue SethTisue self-assigned this Sep 7, 2019
@SethTisue
Copy link
Member

the 2.11 jobs are failing, apparently because of some kind of crosstalk between classpaths during Scaladoc generation:

[error] java.lang.NoClassDefFoundError: scala/util/parsing/json/JSONArray

in 2.11, scala-compiler still depended on scala-parser-combinators, that isn't true from 2.12 on

@ashawley did we run into something comparable over in scala-xml?

@eed3si9n is it obvious to you why this might be different in 1.3.0?

@SethTisue SethTisue removed their assignment Sep 9, 2019
@Philippus
Copy link
Member

Philippus commented Sep 9, 2019

is this a repeat/variant of #197 ?

@Philippus
Copy link
Member

Philippus commented Sep 9, 2019

I think this is the same issue as sbt/sbt#4995.
The workaround mention in sbt/sbt#4995 (comment) works locally for me as well (adding ThisBuild / useCoursier := false).

@SethTisue
Copy link
Member

since only two repos in the world are affected, I think it's fine to go ahead with that workaround. want to do the honors? (you can push additional commits onto scala-steward's branches)

@SethTisue
Copy link
Member

I suppose the workaround could be limited to the 2.11 case only, and we leave coursier enabled for the other Scala versions? but whatevs, nbd either way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants