-
Notifications
You must be signed in to change notification settings - Fork 130
Removed JSON deprecation warnings #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM, thanks! Now I am wondering why only the JSON package got deprecated... @soc: was there any other reason for this being deprecated, apart from the move (you deprecated it in scala/scala@3e1a075)? |
Yes, the disastrous performance. You shouldn't be using scala-parser-combinators in the first place, but the toy implementation of JSON was just even more misleading than the existence of parser combinators in the standard library, because users thought it was intended for usage in production. Basically, the whole split-into-a-module was a way to get rid of it as fast as possible. Just like for akka-actors, it would be good to write a migration document to move scala-parser-combinator code to parboiled2 and let scala-parser-combinators die. So the right action is to add There is no point in keeping scala-parser-combinators alive longer than necessary. |
Removed JSON deprecation warnings
@soc thanks, that makes sense. I never used the JSON implementation... I agree on the need for a migration guide, I'll look into that (first I need to refresh my understanding of parboiled2). |
Let's mention @sirthias, so he's aware of what's happening here. |
Thanks for the ping, Simon! |
Was the decision to un-deprecate discussed somewhere, or only on this ticket? |
@retronym directed me to https://issues.scala-lang.org/browse/SI-8863 (which links to more extensive discussion at https://groups.google.com/d/msg/scala-user/nT15jFY7CgE/CiXPZeTP5A0J) |
Removes the deprecation warnings which were added to JSON objects and classes prior to their removal from the Scala standard library. Now that this project has been branched into a separate module, the deprecation warnings can be removed.