Skip to content

Change apostrophe in error message #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2016
Merged

Conversation

egulias
Copy link
Contributor

@egulias egulias commented Jul 19, 2016

I'm not sure if this was intentionally left with ' instead of "`" in the closing apostrophe, but just in case it was not I made the PR.
Scala CLA has been signed.

@SethTisue
Copy link
Member

SethTisue commented Aug 9, 2016

pairing of with ' is a LaTeX-ism, so it was probably intentional, but that doesn't mean it's desirable. I'd suggest using regular single quote ' instead of. paired ` is a Markdown-ism which isn't any more appropriate here than LaTeX

@egulias
Copy link
Contributor Author

egulias commented Sep 3, 2016

Didn't see the edited comment, I'll change it. Sorry for the delay.

I'm not sure if this was intentionally left with `'` instead of ` in the closing apostrophe, but just in case it was not I made the PR.
Scala CLA has been signed.
@egulias
Copy link
Contributor Author

egulias commented Sep 4, 2016

Is there a way to relaunch tests? It is a failure with openjdk7 (https://travis-ci.org/scala/scala-parser-combinators/jobs/157424627), an overflow with core dump. I guess it has nothing to do with the actual changes.

@danslapman
Copy link

danslapman commented Sep 5, 2016

@egulias I'd been facing the same error in scala-continuations, it can be fixed the following way: PR

@danslapman
Copy link

Alternatively You can update the previos workaround this way

@SethTisue
Copy link
Member

for now I just hit the "rebuild" button over on Travis

@danslapman
Copy link

"rebuild" will not help in this case

@SethTisue
Copy link
Member

I've opened a separate ticket on the OpenJDK 7 issue: #82

@egulias
Copy link
Contributor Author

egulias commented Sep 8, 2016

Ok, thanks @SethTisue , @danslapman . I'll wait then.

@danslapman
Copy link

@egulias why waiting? Just patch travis file as I suggested...

@danslapman
Copy link

This issue is described here: travis-ci/travis-ci#5227 (comment)
Take a look,

@egulias
Copy link
Contributor Author

egulias commented Sep 8, 2016

Ok, Will do.

El 8/9/2016 9:24 p. m., "danslapman" [email protected] escribió:

This issue is described here: travis-ci/travis-ci#5227 (comment)
travis-ci/travis-ci#5227 (comment)
Take a look,


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#81 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAwU_vafhj8tXFFSbgrG2NV3jqvvFlocks5qoGD2gaJpZM4JQQhG
.

@egulias
Copy link
Contributor Author

egulias commented Sep 10, 2016

Done @danslapman

@gourlaysama gourlaysama merged commit 6582a95 into scala:1.0.x Sep 19, 2016
@gourlaysama
Copy link
Contributor

LGTM, thanks @egulias!
The LaTeX quoting tradition is more confusing than helpful, I think. It should probably be changed everywhere later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants