-
Notifications
You must be signed in to change notification settings - Fork 131
Change apostrophe in error message #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pairing of |
Didn't see the edited comment, I'll change it. Sorry for the delay. |
I'm not sure if this was intentionally left with `'` instead of ` in the closing apostrophe, but just in case it was not I made the PR. Scala CLA has been signed.
Is there a way to relaunch tests? It is a failure with openjdk7 (https://travis-ci.org/scala/scala-parser-combinators/jobs/157424627), an overflow with core dump. I guess it has nothing to do with the actual changes. |
Alternatively You can update the previos workaround this way |
for now I just hit the "rebuild" button over on Travis |
"rebuild" will not help in this case |
I've opened a separate ticket on the OpenJDK 7 issue: #82 |
Ok, thanks @SethTisue , @danslapman . I'll wait then. |
@egulias why waiting? Just patch travis file as I suggested... |
This issue is described here: travis-ci/travis-ci#5227 (comment) |
Ok, Will do. El 8/9/2016 9:24 p. m., "danslapman" [email protected] escribió: This issue is described here: travis-ci/travis-ci#5227 (comment) — |
Done @danslapman |
LGTM, thanks @egulias! |
I'm not sure if this was intentionally left with
'
instead of "`" in the closing apostrophe, but just in case it was not I made the PR.Scala CLA has been signed.