Skip to content

1.0.x branch (inadvertently?) dropped support for Java 6 & 7 and Scala 2.10 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue May 6, 2018 · 4 comments

Comments

@SethTisue
Copy link
Member

SethTisue commented May 6, 2018

it came up over at scala/sbt-scala-module#32 that @Sciss thought scala-swing was built on Java 6. I thought it was too, and the repo readme here claims it is.

but it isn't. it was, but at some point, it changed, perhaps inadvertently. I looks to me like changes were made on the 1.0.x branch that should probably only been made on 2.0.x. this included building on JDK 8 only and also dropping support for Scala 2.10, which the readme also claims 1.0.x supports.

as for the related sbt version issue:

  • I think it's fine for 1.0.x to stay on 0.13.x indefinitely
  • for 2.0.x to move to sbt 1, it would have to drop JDK 6 and 7 support. @Sciss indicated a desire to keep supporting JDK 6 and 7, but I'm not sure if he cares about that on 2.0.x too, or whether keeping the support on the 1.0.x branch is enough. (@Sciss, if you decide 2.0.x should stay on sbt 0.13, that's fine w/ me.)
@Sciss
Copy link
Contributor

Sciss commented May 6, 2018

I do care about keeping the Scala 2.11.x promise of working on JDK 6; so by implication, I think as long as Swing 2.0.x supports Scala 2.11, it should also compile on JDK 6. We can be more relaxed about Travis, but I should at least see if I can test:compile it under JDK 6. And so that means no sbt 1.x for now.

@Sciss
Copy link
Contributor

Sciss commented May 6, 2018

Oh well, I can't even install OpenJDK 6 on Debian Stretch without major hassle. So I actually won't be able to compile on JDK 6 any more, anyways. And thus, no objection changing to sbt 1.x for Swing 2.0.x

@SethTisue
Copy link
Member Author

okay, cool!

@benhutchison
Copy link
Contributor

benhutchison commented May 7, 2018 via email

@Sciss Sciss closed this as completed Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants