Skip to content

Publish Scala.js artifacts for 1.0.0-RC1 #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ashawley opened this issue Nov 29, 2019 · 12 comments
Closed

Publish Scala.js artifacts for 1.0.0-RC1 #373

ashawley opened this issue Nov 29, 2019 · 12 comments

Comments

@ashawley
Copy link
Member

https://www.scala-js.org/news/2019/11/26/announcing-scalajs-1.0.0-RC1/

This needs to be done for 1.2.0 series, and possibly should be done for the 2.0.0-M1 milestone of scala-xml.

@ashawley
Copy link
Member Author

It didn't work on the 1.x branch. Maybe because it still uses sbt 0.13.18?

[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: org.scala-js#sbt-scalajs;1.0.0-RC1: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 
[warn] 	Note: Some unresolved dependencies have extra attributes.  Check that these dependencies exist with the requested attributes.
[warn] 		org.scala-js:sbt-scalajs:1.0.0-RC1 (scalaVersion=2.10, sbtVersion=0.13)
[warn] 
[warn] 	Note: Unresolved dependencies path:
[warn] 		org.scala-js:sbt-scalajs:1.0.0-RC1 (scalaVersion=2.10, sbtVersion=0.13) (/home/travis/build/ashawley/scala-xml/project/plugins.sbt#L11-12)
[warn] 		  +- default:scala-xml-build:0.1-SNAPSHOT (scalaVersion=2.10, sbtVersion=0.13)
sbt.ResolveException: unresolved dependency: org.scala-js#sbt-scalajs;1.0.0-RC1: not found

@ashawley
Copy link
Member Author

Maybe I'll just make the artifacts for 2.0.0-M1...

@ashawley
Copy link
Member Author

ashawley commented Dec 4, 2019

The build script supports publishing artifacts for an old tag with a new Scala version by adding it to the tag name after a #, but it doesn't work for Scala.js targets.

@ashawley
Copy link
Member Author

ashawley commented Dec 4, 2019

Published the tag v2.0.0-M1#sjs_1.0.0-RC1 based on the v2.0.0-M1 tag with logic for publishing Scala.js milestones, which see #376.

@ashawley
Copy link
Member Author

ashawley commented Dec 4, 2019

@lrytz
Copy link
Member

lrytz commented Dec 4, 2019

Maybe this situation is rare enough and we can just create a specific commit for that release? Something like this:
master...lrytz:new-js

Then you could create a tag v2.0.0-M1#sjs_1.0.0-RC1 (the suffix would be ignored).

@ashawley
Copy link
Member Author

ashawley commented Dec 4, 2019

Sure, that's true. And that's what I did. Please weigh in at #376.

@ashawley
Copy link
Member Author

ashawley commented Dec 4, 2019

Could someone on the Scala team inspect Sonatype to see if there was a repository published for scala-xml 2.0.0-M1 with just artifacts for Scala.js 1.0.0-RC1?

@lrytz
Copy link
Member

lrytz commented Dec 4, 2019

There are two staging repositories: https://oss.sonatype.org/content/repositories/orgscala-lang-1976/ and https://oss.sonatype.org/content/repositories/orgscala-lang-1977/
Seems to be fine, but please take a look yourself.

@ashawley
Copy link
Member Author

ashawley commented Dec 4, 2019

Great, thanks. They look ok to me. Please publish.

@lrytz
Copy link
Member

lrytz commented Dec 4, 2019

OK, done. Thanks for doing the release!

@ashawley
Copy link
Member Author

ashawley commented Dec 4, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants