Skip to content

Fix Scaladoc warnings for JDK refs #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2017

Conversation

ashawley
Copy link
Member

For now just validate and create a link and avoid the warning. The links don't deep-link currently, but that can be a follow-up.

Based on code posted at http://stackoverflow.com/questions/16934488

Possibly lift java version from https://github.com/scala/sbt-scala-modules plugin scalaVersionsByJvm.

- Use Java library hack from StackOverflow
- Fix ref to java.io.IOException
@SethTisue
Copy link
Member

I haven't tried it, but perhaps using https://github.com/ThoughtWorksInc/sbt-api-mappings would cover this without having to add custom code like this...?

@ashawley
Copy link
Member Author

ashawley commented May 2, 2017

My sense was it was only for Scala libraries, unfortunately.

@SethTisue
Copy link
Member

ah. well, made the suggestion at ThoughtWorksInc/sbt-api-mappings#6

@ashawley
Copy link
Member Author

ashawley commented May 2, 2017

Cool, thanks. Hopefully, they find it in scope.

@ashawley ashawley merged commit b7f38c6 into scala:master May 5, 2017
@ashawley ashawley deleted the fix-javadoc-links branch May 11, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants