add Java 9 test #179
Closed
add Java 9 test #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashawley
requested changes
Dec 24, 2017
| @@ -50,4 +50,4 @@ if [[ "$TRAVIS_TAG" =~ $tagPat ]]; then | |||
| openssl aes-256-cbc -K $K -iv $IV -in admin/secring.asc.enc -out admin/secring.asc -d | |||
| fi | |||
|
|
|||
| sbt "$publishVersion" "$publishScalaVersion" clean update +test +publishLocal $extraTarget | |||
| sbt -Dsbt.scala.version=2.10.7 "$publishVersion" "$publishScalaVersion" clean update +test +publishLocal $extraTarget | |||
There was a problem hiding this comment.
I saw @SethTisue mention this, but I'd rather avoid breaking fix the build for people.
ashawley
reviewed
Dec 25, 2017
| )) | ||
| .getOrElse(Map.empty) | ||
| } | ||
| } |
There was a problem hiding this comment.
This refactoring actually causes an NPE to silently succeed with the doc task. It's better if the task still fails, IMO.
This part of the sbt config may get replaced by https://github.com/ThoughtWorksInc/sbt-api-mappings
There was a problem hiding this comment.
Sorry, I take this back. We will need to degrade when the Java boostrap classpath is unavailable. I'll be using this PR as a basis for fixing Java 9 including the external doc linking.
|
waiting on scala/sbt-scala-module#32 |
Merged
|
Continuing in #180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #173