Fix ignored stripComments parameter of Utility.serialize #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this and including a test. Looks good to me. Want to amend the commit and use the e-mail you use with GitHub? $ git commit --amend --author 'Olaf Tomczak <your@email>'While you're at it, aybe a more descriptive commit message than "Fix 183"? |
|
Yep, sorry - hope it's acceptable now ;) |
ashawley
changed the title
ashawley
added a commit
that referenced
this pull request
Jan 29, 2018
|
Closed by c924667 |
|
Thanks for fixing up. There was an extra merge commit, but I was able to get it across the finish line. Thanks again for fixing the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #183 - stripComments parameter not working