Fix for #193:deprecate XMLEventReader

[mghildiy]

class XMLEventReader in package pull is deprecated(since 1.1.1)

[ashawley]

Thanks for this.

Doesn't look like your commit is assigned to your GitHub account. Did you configure your e-mail in git? See https://help.github.com/articles/setting-your-commit-email-address-in-git/

After fixing git, you should also update the commit you made here with a command like this:

$ git commit --amend --author 'manish <your@email>'
$ git push -f origin master

It's also good to use a Git workflow with branches, see:

https://help.github.com/articles/github-flow/

[ashawley]

No description provided.

Descriptions in pull requests are usually helpful for reviewiers. For this PR, one thing worth mentioning is what the deprecation message is for the compiler:

class XMLEventReader in package pull is deprecated (since 1.1.1):
XMLEventReader is an old class,potentially not up to expected standards
of quality.Use javax.xml.stream.XMLEventReader instead.

Maybe the deprecation message should just be:

class XMLEventReader in package pull is deprecated (since 1.1.1): Consider
javax.xml.stream.XMLEventReader instead.

[SethTisue]

@mghildiy still interested in pursuing this...?

[mghildiy]

Review comment by @ashawley has been implemented, and committed. Or am I still missing something here?

[SethTisue]

just realized scala.xml.pull.XMLEvent should be deprecated too, shouldn't it?

[ashawley]

Or am I still missing something here?

The deprecated tag message should just be "Consider javax.xml.stream.XMLEventReader instead.". Currently, the message is duplicated by the compiler:

class XMLEventReader in package pull is deprecated (since 1.1.1): class XMLEventReader 
in package pull is deprecated(since 1.1.1):Consider javax.xml.stream.XMLEventReader instead.

[ashawley]

just realized scala.xml.pull.XMLEvent should be deprecated too, shouldn't it?

Yes, it probably should be deprecated, as well.

[ashawley]

LGTM

[ashawley]

I'd suggest rebasing, but your branch name is called master. I guess you could try git pull --rebase upstream master and then git push --force-with-lease origin master, but at your own risk. If not, I can do the rebase to avoid the merge bubble.

[SethTisue]

I don't think there's a problem, the contents of the PR seem fine.

[ashawley]

Merged in 1b951af. Thanks for this contribution.