Use install-jdk.sh for AdoptOpenJDK #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashawley
force-pushed
the
install-jdk.sh
branch
from
9109eb3 to
238c9da
Compare
lrytz
reviewed
Nov 22, 2019
|
Generally, I have no strong feelings about which tool to use to install the JKD. What I care about is:
|
ashawley
force-pushed
the
install-jdk.sh
branch
from
238c9da to
0c2584f
Compare
eed3si9n
reviewed
Nov 22, 2019
|
|
||
| script: ./build.sh | ||
| script: | ||
| - export JAVA_HOME=$HOME/$TRAVIS_JDK_VERSION |
There was a problem hiding this comment.
Is JAVA_HOME necessary here? I avoid it because having JAVA_HOME causes subtle difference in the way sbt behaves with Java code.
There was a problem hiding this comment.
To be honest, I'm just following directions:
https://docs.travis-ci.com/user/languages/java/#switching-jdks-to-java-10-and-up-within-one-job
I presume these incantations are needed because how install-jdk.sh works, but I don't know.
eed3si9n
reviewed
Nov 22, 2019
eed3si9n
reviewed
Nov 22, 2019
eed3si9n
reviewed
Nov 22, 2019
same. |
ashawley
force-pushed
the
install-jdk.sh
branch
from
0c2584f to
1ee3a0b
Compare
ashawley
force-pushed
the
install-jdk.sh
branch
from
1ee3a0b to
1681cc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369 by dropping SDKMAN! and using
install-jdk.sh:https://github.com/sormuras/bach#install-jdksh