-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add convenience attribute operator to NodeSeq #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Compared to the current method of reading the string text of an attribute: (x \ "@bar").text ...the new operator removes the need for a pair of parenthesis and shortens the overall expression by 7 chars : x \@ "bar" Discussion on scala-internals: https://groups.google.com/d/topic/scala-internals/BZ-tfbebDqE/discussion
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1743/ |
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1743/ |
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1032/ |
jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1032/ |
What about |
@soc interesting question - For me, this means that although I feel comfortable with |
btw, I have mailed a signed copy of the Scala CLA to Danielle Chamberlain. |
ping @phaller |
LGTM |
Add convenience attribute operator to NodeSeq
Compared to the current method of reading the string text of an attribute:
...the new operator removes the need for a pair of parenthesis and shortens the overall expression by 7 chars :
Discussion on scala-internals:
https://groups.google.com/d/topic/scala-internals/BZ-tfbebDqE/discussion
Review by @phaller