Apply no warn attachment to binds #6473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning in TypeDiagnostics checks for an attachment where a variable is introduced.
Simple rename to `NoWarnAttachment`. It is still used selectively to turn off unused warning for pattern variables.
|
I'll put it on the 2.12.6 milestone, but I won't be surprised if Adriaan says no... |
|
...warn is a good name for that attachment. He found the previous name irksome. |
adriaanm
approved these changes
Mar 27, 2018
|
Thanks for not being miffed about my shoddy review when you stepped in to redress the regress. |
|
No worries. Thanks for all the delicious omelettes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning in TypeDiagnostics checks for
an attachment where a variable is introduced.
This tweaks Adriaan's tweak.
Note the flag wasn't actually on for the test.
@adriaanm @SethTisue Maybe this is a good candidate for 2.12.6