Improve implementation of classloader caching #7644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
changed the title
retronym
added a commit
to retronym/scala
that referenced
this pull request
Jan 15, 2019
…th JARs Backports: - scala#7366 - scala#7644
retronym
added a commit
to retronym/scala
that referenced
this pull request
Jan 15, 2019
…th JARs Backports: - scala#7366 - scala#7644
retronym
force-pushed
the
topic/classloader-cache-fix
branch
2 times, most recently
from
b186b9f to
d44701b
Compare
mkeskells
suggested changes
Jan 22, 2019
src/compiler/scala/tools/nsc/classpath/ZipAndJarFileLookupFactory.scala
Outdated
Show resolved
Hide resolved
retronym
force-pushed
the
topic/classloader-cache-fix
branch
3 times, most recently
from
e770317 to
b3e1ccb
Compare
retronym
added a commit
to retronym/scala
that referenced
this pull request
Jan 22, 2019
…th JARs Backports: - scala#7366 - scala#7644
- Fix logic error in reference counted closing
- Add a new policy to cache regardless of timestamps and
regardless of directory elements in the classpath.
retronym
force-pushed
the
topic/classloader-cache-fix
branch
from
b3e1ccb to
b4d31c7
Compare
retronym
added a commit
to retronym/scala
that referenced
this pull request
Feb 4, 2019
…th JARs Backports: - scala#7366 - scala#7644
retronym
added a commit
to retronym/scala
that referenced
this pull request
Feb 4, 2019
…th JARs Backports: - scala#7366 - scala#7644
retronym
added a commit
to retronym/scala
that referenced
this pull request
Feb 4, 2019
…th JARs Backports: - scala#7366 - scala#7644
adriaanm
reviewed
Feb 7, 2019
adriaanm
reviewed
Feb 7, 2019
adriaanm
approved these changes
Feb 8, 2019
retronym
added a commit
to retronym/scala
that referenced
this pull request
Feb 20, 2019
…th JARs Backports: - scala#7366 - scala#7644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than disabling caching.