Skip to content

Add workflow CI #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

Add workflow CI #36

merged 1 commit into from
Oct 4, 2021

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki linked an issue Oct 2, 2021 that may be closed by this pull request
Move tests to GitHub Actions #17
Closed
@nicolasstucki nicolasstucki marked this pull request as ready for review October 2, 2021 12:53
@SethTisue
Copy link
Member

the Javas should be temurin not adopt, as per https://github.com/actions/setup-java/blob/v2.3.1/README.md#supported-distributions

@nicolasstucki
Copy link
Contributor Author

termurin does not seem to be available. It failed to find it in https://github.com/scala/scala3-cross.g8/runs/3792914832. It lists the following versions

Java versions 
2021-10-04T15:24:15.9260487Z [email protected]
2021-10-04T15:24:15.9262939Z [email protected]
2021-10-04T15:24:15.9264292Z [email protected]
2021-10-04T15:24:15.9266504Z [email protected]
2021-10-04T15:24:15.9268995Z [email protected]
2021-10-04T15:24:15.9273000Z [email protected]
2021-10-04T15:24:15.9274351Z [email protected]
2021-10-04T15:24:15.9280905Z [email protected]
2021-10-04T15:24:15.9281373Z [email protected]
2021-10-04T15:24:15.9282811Z [email protected]
2021-10-04T15:24:15.9283239Z [email protected]
2021-10-04T15:24:15.9286917Z [email protected]
2021-10-04T15:24:15.9287521Z [email protected]
2021-10-04T15:24:15.9287954Z [email protected]
2021-10-04T15:24:15.9288395Z [email protected]
2021-10-04T15:24:15.9288832Z [email protected]
2021-10-04T15:24:15.9289279Z [email protected]
2021-10-04T15:24:15.9289709Z [email protected]
2021-10-04T15:24:15.9290226Z [email protected]
2021-10-04T15:24:15.9290650Z [email protected]
2021-10-04T15:24:15.9291094Z [email protected]
2021-10-04T15:24:15.9291540Z [email protected]
2021-10-04T15:24:15.9291973Z [email protected]
2021-10-04T15:24:15.9292415Z [email protected]
2021-10-04T15:24:15.9292845Z [email protected]
2021-10-04T15:24:15.9293287Z [email protected]
2021-10-04T15:24:15.9293710Z [email protected]
2021-10-04T15:24:15.9294221Z [email protected]
2021-10-04T15:24:15.9294756Z [email protected]
2021-10-04T15:24:15.9295296Z [email protected]
2021-10-04T15:24:15.9295833Z [email protected]
2021-10-04T15:24:15.9296352Z [email protected]
2021-10-04T15:24:15.9296893Z [email protected]
2021-10-04T15:24:15.9297408Z [email protected]
2021-10-04T15:24:15.9297943Z [email protected]
2021-10-04T15:24:15.9298455Z [email protected]
2021-10-04T15:24:15.9298987Z [email protected]
2021-10-04T15:24:15.9299524Z [email protected]
2021-10-04T15:24:15.9300043Z [email protected]
2021-10-04T15:24:15.9300573Z [email protected]
2021-10-04T15:24:15.9301086Z [email protected]
2021-10-04T15:24:15.9301615Z [email protected]
2021-10-04T15:24:15.9302136Z [email protected]
2021-10-04T15:24:15.9302669Z [email protected]
2021-10-04T15:24:15.9303187Z [email protected]
2021-10-04T15:24:15.9303729Z [email protected]
2021-10-04T15:24:15.9304253Z [email protected]
2021-10-04T15:24:15.9304782Z [email protected]
2021-10-04T15:24:15.9305319Z [email protected]
2021-10-04T15:24:15.9305840Z [email protected]
2021-10-04T15:24:15.9306378Z [email protected]
2021-10-04T15:24:15.9306896Z [email protected]
2021-10-04T15:24:15.9307431Z [email protected]
2021-10-04T15:24:15.9308003Z [email protected]
2021-10-04T15:24:15.9308581Z [email protected]
2021-10-04T15:24:15.9309173Z [email protected]
2021-10-04T15:24:15.9309784Z [email protected]
2021-10-04T15:24:15.9310375Z [email protected]
2021-10-04T15:24:15.9310943Z [email protected]
2021-10-04T15:24:15.9311526Z [email protected]
2021-10-04T15:24:15.9312100Z [email protected]
2021-10-04T15:24:15.9312662Z [email protected]
2021-10-04T15:24:15.9313244Z [email protected]
2021-10-04T15:24:15.9313816Z [email protected]
2021-10-04T15:24:15.9314398Z [email protected]
2021-10-04T15:24:15.9315223Z [email protected]
2021-10-04T15:24:15.9316084Z [email protected]
2021-10-04T15:24:15.9318485Z [email protected]
2021-10-04T15:24:15.9319083Z [email protected]
2021-10-04T15:24:15.9319668Z [email protected]
2021-10-04T15:24:15.9320240Z [email protected]
2021-10-04T15:24:15.9320825Z [email protected]
2021-10-04T15:24:15.9322467Z [email protected]
2021-10-04T15:24:15.9323120Z [email protected]
2021-10-04T15:24:15.9323512Z [email protected]
2021-10-04T15:24:15.9323859Z [email protected]
2021-10-04T15:24:15.9324203Z [email protected]
2021-10-04T15:24:15.9324527Z [email protected]
2021-10-04T15:24:15.9324990Z [email protected]
2021-10-04T15:24:15.9325312Z [email protected]
2021-10-04T15:24:15.9325651Z [email protected]
2021-10-04T15:24:15.9325984Z [email protected]
2021-10-04T15:24:15.9326321Z [email protected]
2021-10-04T15:24:15.9326651Z [email protected]
2021-10-04T15:24:15.9326987Z [email protected]
2021-10-04T15:24:15.9327324Z [email protected]
2021-10-04T15:24:15.9327661Z [email protected]
2021-10-04T15:24:15.9327994Z [email protected]
2021-10-04T15:24:15.9328324Z [email protected]
2021-10-04T15:24:15.9328657Z [email protected]
2021-10-04T15:24:15.9336074Z [email protected]
2021-10-04T15:24:15.9336857Z [email protected]
2021-10-04T15:24:15.9337202Z [email protected]
2021-10-04T15:24:15.9337546Z [email protected]
2021-10-04T15:24:15.9338245Z [email protected]
2021-10-04T15:24:15.9338576Z [email protected]
2021-10-04T15:24:15.9339056Z [email protected]
2021-10-04T15:24:15.9339504Z [email protected]
2021-10-04T15:24:15.9339963Z [email protected]
2021-10-04T15:24:15.9340413Z [email protected]
2021-10-04T15:24:15.9340865Z [email protected]
2021-10-04T15:24:15.9341308Z [email protected]
2021-10-04T15:24:15.9341769Z [email protected]
2021-10-04T15:24:15.9342226Z [email protected]
2021-10-04T15:24:15.9342669Z [email protected]
2021-10-04T15:24:15.9343293Z [email protected]
2021-10-04T15:24:15.9343750Z [email protected]
2021-10-04T15:24:15.9344204Z [email protected]
2021-10-04T15:24:15.9344874Z [email protected]
2021-10-04T15:24:15.9345376Z [email protected]
2021-10-04T15:24:15.9345822Z [email protected]
2021-10-04T15:24:15.9346280Z [email protected]
2021-10-04T15:24:15.9346813Z [email protected]
2021-10-04T15:24:15.9347400Z [email protected]
2021-10-04T15:24:15.9348000Z [email protected]
2021-10-04T15:24:15.9348577Z [email protected]
2021-10-04T15:24:15.9349171Z [email protected]
2021-10-04T15:24:15.9349889Z [email protected]
2021-10-04T15:24:15.9350501Z [email protected]
2021-10-04T15:24:15.9351100Z [email protected]
2021-10-04T15:24:15.9351744Z [email protected]
2021-10-04T15:24:15.9352340Z [email protected]
2021-10-04T15:24:15.9352921Z [email protected]
2021-10-04T15:24:15.9353516Z [email protected]
2021-10-04T15:24:15.9354093Z [email protected]
2021-10-04T15:24:15.9354685Z [email protected]
2021-10-04T15:24:15.9355261Z [email protected]
2021-10-04T15:24:15.9355863Z [email protected]
2021-10-04T15:24:15.9356457Z [email protected]
2021-10-04T15:24:15.9357389Z [email protected]
2021-10-04T15:24:15.9358015Z [email protected]
2021-10-04T15:24:15.9358586Z [email protected]
2021-10-04T15:24:15.9359165Z [email protected]
2021-10-04T15:24:15.9359734Z [email protected]
2021-10-04T15:24:15.9360315Z [email protected]
2021-10-04T15:24:15.9360894Z [email protected]
2021-10-04T15:24:15.9361462Z [email protected]
2021-10-04T15:24:15.9362042Z [email protected]
2021-10-04T15:24:15.9362604Z [email protected]
2021-10-04T15:24:15.9363182Z [email protected]
2021-10-04T15:24:15.9363745Z [email protected]
2021-10-04T15:24:15.9364322Z [email protected]
2021-10-04T15:24:15.9365108Z [email protected]
2021-10-04T15:24:15.9365718Z [email protected]
2021-10-04T15:24:15.9366299Z [email protected]
2021-10-04T15:24:15.9366870Z [email protected]
2021-10-04T15:24:15.9367456Z [email protected]
2021-10-04T15:24:15.9368651Z [email protected]
2021-10-04T15:24:15.9369367Z [email protected]
2021-10-04T15:24:15.9369930Z [email protected]
2021-10-04T15:24:15.9370517Z [email protected]
2021-10-04T15:24:15.9371110Z [email protected]
2021-10-04T15:24:15.9371683Z [email protected]
2021-10-04T15:24:15.9372272Z [email protected]
2021-10-04T15:24:15.9372847Z [email protected]
2021-10-04T15:24:15.9373431Z [email protected]
2021-10-04T15:24:15.9374000Z [email protected]
2021-10-04T15:24:15.9374585Z [email protected]
2021-10-04T15:24:15.9375147Z [email protected]
2021-10-04T15:24:15.9375737Z [email protected]
2021-10-04T15:24:15.9376325Z [email protected]
2021-10-04T15:24:15.9376890Z [email protected]
2021-10-04T15:24:15.9377470Z [email protected]
2021-10-04T15:24:15.9378040Z [email protected]
2021-10-04T15:24:15.9378630Z [email protected]
2021-10-04T15:24:15.9379199Z [email protected]
2021-10-04T15:24:15.9379597Z [email protected]
2021-10-04T15:24:15.9380025Z [email protected]
2021-10-04T15:24:15.9380447Z [email protected]
2021-10-04T15:24:15.9380881Z [email protected]
2021-10-04T15:24:15.9381295Z [email protected]
2021-10-04T15:24:15.9381720Z [email protected]
2021-10-04T15:24:15.9382133Z [email protected]
2021-10-04T15:24:15.9382449Z [email protected]
2021-10-04T15:24:15.9382852Z [email protected]
2021-10-04T15:24:15.9383278Z [email protected]
2021-10-04T15:24:15.9383701Z [email protected]
2021-10-04T15:24:15.9384110Z [email protected]
2021-10-04T15:24:15.9384419Z [email protected]
2021-10-04T15:24:15.9384828Z [email protected]
2021-10-04T15:24:15.9385261Z [email protected]
2021-10-04T15:24:15.9385675Z [email protected]
2021-10-04T15:24:15.9386096Z [email protected]
2021-10-04T15:24:15.9386421Z [email protected]
2021-10-04T15:24:15.9386887Z [email protected]
2021-10-04T15:24:15.9387366Z [email protected]
2021-10-04T15:24:15.9387720Z [email protected]
2021-10-04T15:24:15.9388187Z [email protected]
2021-10-04T15:24:15.9388642Z [email protected]
2021-10-04T15:24:15.9389112Z [email protected]
2021-10-04T15:24:15.9389471Z [email protected]
2021-10-04T15:24:15.9389944Z [email protected]
2021-10-04T15:24:15.9390401Z [email protected]
2021-10-04T15:24:15.9390871Z [email protected]
2021-10-04T15:24:15.9391228Z [email protected]
2021-10-04T15:24:15.9391685Z [email protected]
2021-10-04T15:24:15.9392157Z [email protected]
2021-10-04T15:24:15.9392503Z [email protected]
2021-10-04T15:24:15.9392971Z [email protected]
2021-10-04T15:24:15.9393436Z [email protected]
2021-10-04T15:24:15.9393914Z [email protected]
2021-10-04T15:24:15.9394378Z [email protected]
2021-10-04T15:24:15.9394850Z [email protected]
2021-10-04T15:24:15.9395321Z [email protected]
2021-10-04T15:24:15.9395788Z [email protected]
2021-10-04T15:24:15.9396264Z [email protected]
2021-10-04T15:24:15.9396734Z [email protected]
2021-10-04T15:24:15.9397209Z [email protected]
2021-10-04T15:24:15.9397673Z [email protected]
2021-10-04T15:24:15.9398156Z [email protected]
2021-10-04T15:24:15.9398613Z [email protected]
2021-10-04T15:24:15.9399096Z [email protected]
2021-10-04T15:24:15.9399579Z [email protected]
2021-10-04T15:24:15.9400044Z [email protected]
2021-10-04T15:24:15.9400522Z [email protected]
2021-10-04T15:24:15.9400876Z [email protected]
2021-10-04T15:24:15.9401341Z [email protected]
2021-10-04T15:24:15.9401681Z [email protected]
2021-10-04T15:24:15.9402140Z [email protected]
2021-10-04T15:24:15.9402591Z [email protected]
2021-10-04T15:24:15.9402945Z [email protected]
2021-10-04T15:24:15.9403406Z [email protected]
2021-10-04T15:24:15.9403858Z [email protected]
2021-10-04T15:24:15.9404212Z [email protected]
2021-10-04T15:24:15.9404658Z [email protected]
2021-10-04T15:24:15.9405378Z [email protected]
2021-10-04T15:24:15.9405721Z [email protected]
2021-10-04T15:24:15.9406188Z [email protected]
2021-10-04T15:24:15.9406647Z [email protected]
2021-10-04T15:24:15.9407007Z [email protected]
2021-10-04T15:24:15.9407474Z [email protected]
2021-10-04T15:24:15.9407929Z [email protected]
2021-10-04T15:24:15.9408281Z [email protected]
2021-10-04T15:24:15.9408730Z [email protected]
2021-10-04T15:24:15.9409447Z [email protected]
2021-10-04T15:24:15.9409797Z [email protected]
2021-10-04T15:24:15.9410269Z [email protected]
2021-10-04T15:24:15.9410744Z [email protected]
2021-10-04T15:24:15.9411216Z [email protected]
2021-10-04T15:24:15.9411728Z [email protected]
2021-10-04T15:24:15.9412213Z [email protected]
2021-10-04T15:24:15.9412711Z [email protected]
2021-10-04T15:24:15.9413195Z [email protected]
2021-10-04T15:24:15.9413696Z [email protected]
2021-10-04T15:24:15.9414172Z [email protected]
2021-10-04T15:24:15.9414667Z [email protected]
2021-10-04T15:24:15.9415159Z [email protected]
2021-10-04T15:24:15.9415642Z [email protected]
2021-10-04T15:24:15.9416129Z [email protected]
2021-10-04T15:24:15.9416616Z [email protected]
2021-10-04T15:24:15.9417110Z [email protected]
2021-10-04T15:24:15.9417589Z [email protected]
2021-10-04T15:24:15.9418079Z [email protected]
2021-10-04T15:24:15.9418621Z [email protected]
2021-10-04T15:24:15.9419119Z [email protected]
2021-10-04T15:24:15.9419619Z [email protected]
2021-10-04T15:24:15.9420071Z [email protected]
2021-10-04T15:24:15.9420396Z [email protected]
2021-10-04T15:24:15.9420814Z [email protected]
2021-10-04T15:24:15.9421139Z [email protected]
2021-10-04T15:24:15.9421548Z [email protected]
2021-10-04T15:24:15.9421977Z [email protected]
2021-10-04T15:24:15.9422397Z [email protected]
2021-10-04T15:24:15.9422718Z [email protected]
2021-10-04T15:24:15.9423147Z [email protected]
2021-10-04T15:24:15.9423561Z [email protected]
2021-10-04T15:24:15.9423989Z [email protected]
2021-10-04T15:24:15.9424295Z [email protected]
2021-10-04T15:24:15.9424716Z [email protected]
2021-10-04T15:24:15.9425130Z [email protected]
2021-10-04T15:24:15.9425564Z [email protected]
2021-10-04T15:24:15.9425977Z [email protected]
2021-10-04T15:24:15.9426409Z [email protected]
2021-10-04T15:24:15.9426833Z [email protected]
2021-10-04T15:24:15.9427244Z [email protected]
2021-10-04T15:24:15.9427673Z [email protected]
2021-10-04T15:24:15.9428346Z grep temurin@11
2021-10-04T15:24:15.9428810Z head { '-n': 1 }
2021-10-04T15:24:15.9429774Z exec curl -sL https://raw.githubusercontent.com/sbt/sbt/develop/sbt { silent: true }
2021-10-04T15:24:15.9430522Z [email protected]
2021-10-04T15:24:15.9430964Z [email protected]
2021-10-04T15:24:15.9431375Z [email protected]
2021-10-04T15:24:15.9431692Z [email protected]
2021-10-04T15:24:15.9432116Z [email protected]
2021-10-04T15:24:15.9432536Z [email protected]
2021-10-04T15:24:15.9432969Z [email protected]
2021-10-04T15:24:15.9433383Z [email protected]
2021-10-04T15:24:15.9433809Z [email protected]
2021-10-04T15:24:15.9434223Z [email protected]
2021-10-04T15:24:15.9434647Z [email protected]
2021-10-04T15:24:15.9435059Z [email protected]
2021-10-04T15:24:15.9435482Z [email protected]
2021-10-04T15:24:15.9435909Z [email protected]
2021-10-04T15:24:15.9436321Z [email protected]
2021-10-04T15:24:15.9436642Z [email protected]
2021-10-04T15:24:15.9437051Z [email protected]
2021-10-04T15:24:15.9437481Z [email protected]
2021-10-04T15:24:15.9437783Z [email protected]
2021-10-04T15:24:15.9438206Z [email protected]
2021-10-04T15:24:15.9438622Z [email protected]
2021-10-04T15:24:15.9439050Z [email protected]
2021-10-04T15:24:15.9439477Z [email protected]
2021-10-04T15:24:15.9439787Z [email protected]
2021-10-04T15:24:15.9440106Z [email protected]
2021-10-04T15:24:15.9440407Z [email protected]
2021-10-04T15:24:15.9440718Z [email protected]
2021-10-04T15:24:15.9441016Z [email protected]
2021-10-04T15:24:15.9441331Z [email protected]
2021-10-04T15:24:15.9441632Z [email protected]
2021-10-04T15:24:15.9441949Z [email protected]
2021-10-04T15:24:15.9442256Z [email protected]
2021-10-04T15:24:15.9442554Z [email protected]
2021-10-04T15:24:15.9442865Z [email protected]
2021-10-04T15:24:15.9443164Z [email protected]
2021-10-04T15:24:15.9443474Z [email protected]
2021-10-04T15:24:15.9443770Z [email protected]
2021-10-04T15:24:15.9444086Z [email protected]
2021-10-04T15:24:15.9444387Z [email protected]
2021-10-04T15:24:15.9444695Z [email protected]
2021-10-04T15:24:15.9445563Z [email protected]
2021-10-04T15:24:15.9445871Z [email protected]
2021-10-04T15:24:15.9446191Z [email protected]
2021-10-04T15:24:15.9446491Z [email protected]
2021-10-04T15:24:15.9446810Z [email protected]
2021-10-04T15:24:15.9447112Z [email protected]
2021-10-04T15:24:15.9447426Z [email protected]
2021-10-04T15:24:15.9447979Z [email protected]
2021-10-04T15:24:15.9448307Z [email protected]
2021-10-04T15:24:15.9448605Z [email protected]
2021-10-04T15:24:15.9448925Z [email protected]
2021-10-04T15:24:15.9449241Z [email protected]
2021-10-04T15:24:15.9449541Z [email protected]
2021-10-04T15:24:15.9449855Z [email protected]
2021-10-04T15:24:15.9450156Z [email protected]
2021-10-04T15:24:15.9450473Z [email protected]
2021-10-04T15:24:15.9450772Z [email protected]
2021-10-04T15:24:15.9451089Z [email protected]
2021-10-04T15:24:15.9451388Z [email protected]
2021-10-04T15:24:15.9451703Z [email protected]
2021-10-04T15:24:15.9452023Z [email protected]
2021-10-04T15:24:15.9452322Z [email protected]
2021-10-04T15:24:15.9452637Z [email protected]
2021-10-04T15:24:15.9452935Z [email protected]
2021-10-04T15:24:15.9453258Z [email protected]
2021-10-04T15:24:15.9453565Z [email protected]
2021-10-04T15:24:15.9453881Z [email protected]
2021-10-04T15:24:15.9454181Z [email protected]
2021-10-04T15:24:15.9454496Z [email protected]
2021-10-04T15:24:15.9454811Z [email protected]
2021-10-04T15:24:15.9455113Z [email protected]
2021-10-04T15:24:15.9455431Z [email protected]
2021-10-04T15:24:15.9455738Z [email protected]
2021-10-04T15:24:15.9456052Z [email protected]
2021-10-04T15:24:15.9456366Z [email protected]
2021-10-04T15:24:15.9456697Z [email protected]
2021-10-04T15:24:15.9457000Z [email protected]
2021-10-04T15:24:15.9457320Z [email protected]
2021-10-04T15:24:15.9457643Z [email protected]
2021-10-04T15:24:15.9457988Z [email protected]
2021-10-04T15:24:15.9458310Z [email protected]
2021-10-04T15:24:15.9458617Z [email protected]
2021-10-04T15:24:15.9458934Z [email protected]
2021-10-04T15:24:15.9459237Z [email protected]

Let's fix this in a separate PR. We have the same issue in all the other scala3.g8 project.

@SethTisue
Copy link
Member

SethTisue commented Oct 4, 2021 •
edited
Loading

I believe it didn't work because you're using setup-scala, which uses Jabba instead of using setup-java. (Sorry, I should have noticed that before.)

I do not believe we should be using setup-scala at all. Maintenance of it lags, and it doesn't give us anything we want that setup-java doesn't also provide. At one point it might have had a good reason to exist but I don't see one now.

I'm just using setup-java in all the repos I manage.

@anatoliykmetyuk anatoliykmetyuk merged commit 89450eb into scala:main Oct 4, 2021
This was referenced Oct 8, 2021
Merged
Merged
Merged
nicolasstucki added a commit to nicolasstucki/scala3.g8 that referenced this pull request Oct 9, 2021
@nicolasstucki
Stop using adopt JDK
5d4616b 
Based on scala/scala3-cross.g8#36 (comment)
@nicolasstucki nicolasstucki mentioned this pull request Oct 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatoliykmetyuk anatoliykmetyuk anatoliykmetyuk approved these changes

Assignees

@anatoliykmetyuk anatoliykmetyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move tests to GitHub Actions
3 participants
@nicolasstucki @SethTisue @anatoliykmetyuk