wip 11: back to single signature

Author: bishabosha

compiler/src/dotty/tools/dotc/core/tasty/TreeUnpickler.scala

@@ -1197,18 +1197,9 @@ class TreeUnpickler(reader: TastyReader,
                 makeSelect(qual, name, accessibleDenot(qualType, name, sig, target))
               val res = symname match
                 case SignedName(name, sig, target) =>
-                  val pre = ctx.typeAssigner.maybeSkolemizePrefix(qualType, name)
-                  val isAmbiguous = pre.nonPrivateMember(name).match
-                    case d: MultiDenotation =>
-                      d.atSignature(sig, target).isInstanceOf[MultiDenotation]
-                    case _ => false
-                  if isAmbiguous then
-                    makeSelect(qual, name, space.decl(name).atSignature(sig, target).asSeenFrom(pre))
-                  else
-                    select(name, sig, target)
+                  select(name, sig, target)
                 case name =>
                   makeSelect(qual, name, accessibleDenot(qualType, name, Signature.NotAMethod, EmptyTermName))
-                  // select(name, Signature.NotAMethod, EmptyTermName)
               res
             case REPEATED =>
               val elemtpt = readTpt()

compiler/src/dotty/tools/dotc/core/unpickleScala2/Scala2Unpickler.scala

@@ -169,7 +169,7 @@ class Scala2Unpickler(bytes: Array[Byte], classRoot: ClassDenotation, moduleClas
 
   protected def handleRuntimeException(ex: RuntimeException)(using Context): Nothing = ex match {
     case ex: BadSignature => throw ex
-    case _ => errorBadSignature(s"a runtime exception occurred: $ex at ${ex.getStackTrace.mkString("\n")}", Some(ex))
+    case _ => errorBadSignature(s"a runtime exception occurred: $ex", Some(ex))
   }
 
   def run()(using Context): Unit =

compiler/test/dotty/tools/dotc/FromTastyTests.scala

@@ -13,17 +13,6 @@ class FromTastyTests {
   import TestConfiguration._
   import FromTastyTests._
 
-  // @Test def postmpTestFromTasty: Unit = {
-  //   // Can be reproduced with
-  //   // > sbt
-  //   // > scalac -Ythrough-tasty -Ycheck:all <source>
-
-  //   implicit val testGroup: TestGroup = TestGroup("posTestFromTasty")
-  //   compileTastyInDir(s"tests${JFile.separator}pos-tmp", defaultOptions,
-  //     fromTastyFilter = FileFilter.exclude(TestSources.posFromTastyBlacklisted)
-  //   ).checkCompile()
-  // }
-
   @Test def posTestFromTasty: Unit = {
     // Can be reproduced with
     // > sbt

tasty/src/dotty/tools/tasty/TastyFormat.scala

@@ -709,7 +709,7 @@ object TastyFormat {
    */
   def numRefs(tag: Int): Int = tag match {
     case VALDEF | DEFDEF | TYPEDEF | TYPEPARAM | PARAM | NAMEDARG | RETURN | BIND |
-         SELFDEF | REFINEDtype | TERMREFin | TYPEREFin | HOLE | SELECTin => 1
+         SELFDEF | REFINEDtype | TERMREFin | TYPEREFin | SELECTin | HOLE => 1
     case RENAMED | PARAMtype => 2
     case POLYtype | TYPELAMBDAtype | METHODtype => -1
     case _ => 0

tests/pos-tmp/avoid.scala

@@ -1,6 +1,6 @@
 class Buf[A] {
   def append(a: A): this.type = this
-  // def append(a: A*): this.type = this
+  def append(a: A*): this.type = this
 }
 
 @main def Test = {