Skip to content

Broken script files in branch "release-3.3.5" (LTS) #22460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michelou opened this issue Jan 26, 2025 · 1 comment
Closed

Broken script files in branch "release-3.3.5" (LTS) #22460

michelou opened this issue Jan 26, 2025 · 1 comment
Assignees
Labels
itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label

Comments

@michelou
Copy link
Contributor

Compiler versions

3.3.5-RC2
3.3.5-RC3

Cause

PR 22377 (version change of JLine libraries, in particular JNA to JNI dependency change).

Affected script files in release-3.3.5 branch :

scala3/dist/bin/common
scala3/dist/bin/common.bat
scala3/dist/bin/scala.bat
scala3/dist/bin/scalac.bat.
scala3/dist/bin/scaladoc
scala3/dist/bin/scaladoc.bat

NB. Both script files scala and scalac do not reference the JLine libraries and are thus ok IMO.

Required changes

Let's take scala3/dist/bin/common as an example :

  1. Lines 159 and 187 : change name JNA to JNI.
  2. Lines 160-162 and 188 : remove.

NB. Same reasoning for the other script files.

Expectation

3.3.5-RC4 (new release candidate with updated script files).

@michelou michelou added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Jan 26, 2025
@michelou
Copy link
Contributor Author

@WojciechMazur I apparently lost my permission to change the properties in the right column, in particular "Assignees", "Labels" and "Type".

@michelou michelou changed the title Broken script files in branch "release-3.3.5" Broken script files in branch "release-3.3.5" (LTS) Jan 26, 2025
@WojciechMazur WojciechMazur self-assigned this Jan 27, 2025
WojciechMazur added a commit that referenced this issue Jan 27, 2025
* Remove JNA dependencies from dist scripts. 
* Add `jline-native` dependency (used by jline-terminal-jni)

Issue affected only Windows users - when executing the script the no
longer existing class path entries (jna-5, and jline-terminal-jna) were
reported with errors as not existing files

Fixes #22460 
Forward-portable to Scala Next legacy runner scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label
Projects
None yet
Development

No branches or pull requests

2 participants