Stop depending on scala-reflect #2271
Comments
smarter
added a commit
to dotty-staging/dotty
that referenced
this issue
Apr 26, 2017
Since scala#2191, `dotty.tools.dotc.io.PlainFile` is no longer an alias for `scala.reflect.io.PlainFile` but its own class. However, the backend still uses PlainFile from scala.reflect. This mess should soon be fixed by getting rid of scala-reflect (scala#2271). Meanwhile, this commit fixes ExtractDependencies to pattern match on the correct class, and thus avoid missing dependencies.
smarter
added a commit
to dotty-staging/dotty
that referenced
this issue
Apr 26, 2017
Since scala#2191, `dotty.tools.dotc.io.PlainFile` is no longer an alias for `scala.reflect.io.PlainFile` but its own class. However, the backend still uses PlainFile from scala.reflect. This mess should soon be fixed by getting rid of scala-reflect (scala#2271). Meanwhile, this commit fixes ExtractDependencies to pattern match on the correct class, and thus avoid missing dependencies.
|
Fixed a while ago. |
|
Do you mean it can be removed from: https://github.com/lampepfl/dotty/blob/211cc8f1d0d06a45a70e6b7b4c6e5a9468abb5d4/project/Build.scala#L1167 |
|
This one is just a dummy we create in our build, not the real scala-reflect that we used to depend on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After the hyper bootstrap and #2062, the remaining uses of scala-reflect are:
scala.reflect.io.*, should be replaced by our own abstraction layer (@felixmulder is working on one).scala.reflect.internal.util.WeakHashSetused only in the backend, should be copy-pasted into the dotty sources.The text was updated successfully, but these errors were encountered: