Skip to content

No warning emitted with ImplicitConverter when language.implicitConversions is not imported #5351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Duhemm opened this issue Oct 31, 2018 · 0 comments
Closed

No warning emitted with ImplicitConverter when language.implicitConversions is not imported #5351

Duhemm opened this issue Oct 31, 2018 · 0 comments
Labels
itype:question stat:needs spec

Comments

@Duhemm
Copy link
Contributor

Duhemm commented Oct 31, 2018 •
edited
Loading

Defining a value of type ImplicitConverter doesn't emit a warning, like it does when defining an implicit conversion when scala.language.implicitConversions is not in scope.

object O {
  implicit def foo(x: Int): String = x.toString // Emits a warning
  implicit val bar: ImplicitConverter[Int, String] = _.toString // No warning
}

Is this intentional?
Duhemm added a commit to dotty-staging/dotty that referenced this issue Nov 1, 2018
@Duhemm
Fix scala#5351: Warn conversion with ImplicitConverter
1f2022d 
As we do for implicit conversions, we now emit a warning when an
implicit conversion using `ImplicitConverter` is defined or used.

Fixes scala#5351
@Duhemm Duhemm mentioned this issue Nov 1, 2018
Merged
odersky added a commit that referenced this issue Nov 1, 2018
@odersky
Merge pull request #5363 from dotty-staging/fix/5351
77dc93e 
Fix #5351: Warn about implicit conversions using ImplicitConverter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
itype:question stat:needs spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Duhemm