Skip to content

Missing constructor for Term.Ident #5951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liufengyun opened this issue Feb 20, 2019 · 1 comment
Closed

Missing constructor for Term.Ident #5951

liufengyun opened this issue Feb 20, 2019 · 1 comment

Comments

@liufengyun
Copy link
Contributor

In addition to constructors for Term.Select (#5796), we need constructor for Term.Ident as well in implementing Monocle macros (#5941) . Something similar to that in tpd.scala would be ideal:

def Ident(tp: TermRef)(implicit ctx: Context): Ident

However, currently there are both SymRef and TermRef in tasty reflect, which are not subtype of each other. This makes the API fragmented.

Any ideas @nicolasstucki ?
@liufengyun
Copy link
Contributor Author

Implemented in #5944 based on TermRef.

@liufengyun liufengyun mentioned this issue Mar 19, 2019
Closed
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liufengyun