Add constructors for Select #5796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
add-select-constructor
branch
from
8d2127f to
6da8f6f
Compare
liufengyun
changed the title
liufengyun
force-pushed
the
add-select-constructor
branch
2 times, most recently
from
c33cb51 to
0851b30
Compare
|
@nicolasstucki It would be nice if we can get this in recently to unblock @cheeseng and make progress on ScalaTest. |
liufengyun
force-pushed
the
add-select-constructor
branch
from
080adfb to
78259a1
Compare
liufengyun
force-pushed
the
add-select-constructor
branch
from
78259a1 to
29d4ccb
Compare
|
@nicolasstucki Can you give it another look? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5567 to add contructors for Select
Add constructors for Select. The usage of
Select.copyis possible sometimes instead of the constructors. However,Select.copyis not as expressive, verbose, the semantics is unspecified, and it causes weird exceptions in ScalaTest.