Skip to content

Only allow jar and tasty as input for -from-tasty #10003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Oct 14, 2020

This ensures that we don't accidentally load other versions of the classes that are on the current classpath.

TastyInspector and all tests have already been updated in previous PRs.

@nicolasstucki nicolasstucki force-pushed the fix-from-tasty-inputs branch 3 times, most recently from 2e4e3c0 to 68342ba Compare October 15, 2020 08:15
@nicolasstucki nicolasstucki self-assigned this Oct 15, 2020
@nicolasstucki nicolasstucki force-pushed the fix-from-tasty-inputs branch 5 times, most recently from f2937db to 11925ef Compare October 26, 2020 08:34
@nicolasstucki nicolasstucki force-pushed the fix-from-tasty-inputs branch 4 times, most recently from 64b7577 to 4a821a0 Compare November 4, 2020 08:41
@nicolasstucki nicolasstucki marked this pull request as ready for review November 4, 2020 10:54
@nicolasstucki nicolasstucki added this to the 3.0.0 milestone Nov 4, 2020
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 6c0df68 into scala:master Nov 4, 2020
@nicolasstucki nicolasstucki deleted the fix-from-tasty-inputs branch November 4, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants