Fix #10143 and test stdlib from TASTy directly from Jar and TASTy files #10154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing the class names will no be supported in the future.
bishabosha
reviewed
Nov 3, 2020
nicolasstucki
changed the title
nicolasstucki
changed the title
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
test-stdlib-from-tasty-directly-from-jar
branch
from
9047a32 to
5fe3369
Compare
smarter
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we test that the
-from-tastycompilation works on the std lib for a jar or individual tasty files.We also fix #10143 as this failure shows up in the second set of tests. We did not parse correctly the name of the package if it was represented with a
SHAREDtypein TASTy. Now we follow the shared type and read its name.