Remove internal.quoted.{ExprCastError, ScopeException} #10229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
changed the title
liufengyun
approved these changes
Nov 9, 2020
| @@ -25,7 +25,7 @@ package scala { | |||
| case '{$x: Foo} => Expr(run(x).x) | |||
| } | |||
| } catch { | |||
| case ex: scala.internal.quoted.ScopeException => | |||
| case ex: Exception if ex.getMessage == "Cannot call `scala.quoted.staging.run(...)` within a macro or another `run(...)`" => | |||
There was a problem hiding this comment.
The test is a little brittle. I guess it is temporary given the other refactoring is in process.
There was a problem hiding this comment.
Maybe I manage to create the exception class in the compiler code. Then the tests would need to have the compiler in the classpath to know that exception type. For this I must first move the implementation of scala.internal.quoted.Expr into the compiler which is in process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10222