Encode pickled primitives directly using reflection #10232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Step towards #10222 |
nicolasstucki
force-pushed
the
reify-null-and-unit-quotes-directly-as-literals
branch
2 times, most recently
from
86d8b30 to
fa93686
Compare
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
reify-null-and-unit-quotes-directly-as-literals
branch
from
fa93686 to
c60ee85
Compare
This removes the need of some extra helper methods in the internal package. Also add `asExpr` to have a variant of `asExprOf[Any]` that does not need the extra type test at runtime.
…` directly This removes the need of some extra helper methods in the internal package.
nicolasstucki
force-pushed
the
reify-null-and-unit-quotes-directly-as-literals
branch
from
c60ee85 to
bff91a8
Compare
smarter
reviewed
Nov 8, 2020
| * '{ val x: t = ... } | ||
| * ``` | ||
| */ | ||
| def asType: scala.quoted.Type[?] |
There was a problem hiding this comment.
what's the difference with seal?
There was a problem hiding this comment.
I find the name asType is not as informative as seal, because the name Type in the context of TypeRepr is vague, it could refer to both TypeRepr and quoted.Type.
There was a problem hiding this comment.
The next step is to find a way to inject this type in the context directly. Something like
typeRep.asTypeInContext { [T] =>>
// Type[T] is given in this context
}
def asTypeInContext[U](body: [T] =>> (using Type[T]) => U): U = ...
liufengyun
approved these changes
Nov 9, 2020
| * '{ val x: t = ... } | ||
| * ``` | ||
| */ | ||
| def asType: scala.quoted.Type[?] |
There was a problem hiding this comment.
I find the name asType is not as informative as seal, because the name Type in the context of TypeRepr is vague, it could refer to both TypeRepr and quoted.Type.
nicolasstucki
deleted the
reify-null-and-unit-quotes-directly-as-literals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need of some extra helper methods in the internal package.
Add
asExprto have a variant ofasExprOf[Any]that does not need the extra type test at runtime.Also add an equivalent
asTypemethod.