Encode unpickle call directly on context #10238
Conversation
|
Part of #10222 |
| val tree = PickledQuotes.unpickleTerm(pickledQuote)(using reflect.rootContext) | ||
| new scala.internal.quoted.Expr(tree, hash) | ||
| new scala.internal.quoted.Expr(tree, hash).asInstanceOf[scala.quoted.Expr[T]] |
There was a problem hiding this comment.
It seems to me that the original type signature is better. By returning the type Expr[T], there are no guarantees.
There was a problem hiding this comment.
Indeed, there are no guarantees. Calls to this method should only be inserted be the compiler.
The previous version added the cast after each call to this method, effectively having the same guaranties.
I will add some extra documentation to make it clear that no one should be calling this method directly. Currently, it is hidden from the user as it is defined in QuoteContextInteranal.
There was a problem hiding this comment.
In general, all methods in QuoteContextInteranal should only be called by code generated by the compiler or something in the library.
This removes the internal methods
PickledQuoted.{unpickleExpr, unpickleType}