Encode quote pattern matches directly on QuoteContext #10246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also split `Expr.ofTupleFromSeq` into parts to use switch and reduce code size. That method had 400+ quoted pattern matches.
nicolasstucki
force-pushed
the
encode-quote-pattern-match-directly-on-quote-context
branch
from
deecadf to
330cc0b
Compare
liufengyun
approved these changes
Nov 9, 2020
| @@ -18,7 +18,8 @@ abstract class Expr[+T] private[scala] { | |||
| * ``` | |||
| */ | |||
| final def matches(that: Expr[Any])(using qctx: QuoteContext): Boolean = | |||
| !scala.internal.quoted.Expr.unapply[EmptyTuple, EmptyTuple](this)(using that, qctx).isEmpty | |||
| val ExprMatch = qctx.asInstanceOf[scala.internal.quoted.QuoteContextInternal].ExprMatch | |||
| ExprMatch.unapply[EmptyTuple, EmptyTuple](this)(using that).nonEmpty | |||
There was a problem hiding this comment.
From the usage, it seems to me ExprMatch and TypeMatch does not make it simpler. Do we have places where they are used as extractors?
There was a problem hiding this comment.
This is the only place in the library where it is needed. But I plan to move this implementation out of the library and then I might not even need to have this call and could call the tree pattern matcher directly.
This is another method that should only be called from code generated by the compiler.
nicolasstucki
deleted the
encode-quote-pattern-match-directly-on-quote-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode quote pattern matches directly on QuoteContext.
Also, split
Expr.ofTupleFromSeqinto parts to use switch and reduce code size.That method had 200+ quoted pattern matches.
Part of #10222