Fix example code from How to write a type class derived method using macros #10382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I just signed the CLA) |
smarter
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Thanks! @nicolasstucki Can you double-check that this is still a good example for the documentation?
nicolasstucki
approved these changes
Nov 19, 2020
|
Thank you @ghostdogpr |
smarter
reviewed
Nov 19, 2020
| case '[String *: $tpes] => '{ summon[Eq[String]] } :: summonAll(tpes) | ||
| case '[Int *: $tpes] => '{ summon[Eq[Int]] } :: summonAll(tpes) | ||
| case '[$tpe *: $tpes] => derived(using tpe, qctx) :: summonAll(tpes) | ||
| def summonAll[T: Type](using qctx: QuoteContext): List[Expr[Eq[_]]] = t match { |
There was a problem hiding this comment.
@nicolasstucki Does this actually compile? I don't see where t is defined here. Also if we update the doc we should keep the test case synchronized: https://github.com/lampepfl/dotty/blob/master/tests/run-macros/i8007/Macro_3.scala
There was a problem hiding this comment.
I missed that. I will fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10381