community-build: update many projects #10503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
update-scalatest-to-3.2.x-new
branch
10 times, most recently
from
46ba334 to
502df89
Compare
smarter
changed the title
smarter
force-pushed
the
update-scalatest-to-3.2.x-new
branch
from
502df89 to
dbb9e25
Compare
smarter
force-pushed
the
update-scalatest-to-3.2.x-new
branch
3 times, most recently
from
b6d0dfa to
41c11cd
Compare
griggt
reviewed
Nov 30, 2020
smarter
force-pushed
the
update-scalatest-to-3.2.x-new
branch
2 times, most recently
from
1f1e349 to
2f6c469
Compare
griggt
approved these changes
Dec 1, 2020
- We start by updating scalatest (thanks Nicolas), with an extra commit to increase the heapsize otherwise it wouldn't run on the CI. - scalatestplus-scalacheck had to upgraded too. - upickle/ujson do not depend on scalatest when building with dotty currently so we can drop the dependency in projects.scala. - updated scodec/scodec-bits to latest upstream which doesn't depend on scalatest anymore, but does depend on munit, which I also upgraded, a few tweaks to these projects were required. - the upgraded munit required a patch because MacroCompat was in scala-3.0.0-M2 but we need it to work with our snapshots releases, so I copy-pasted it to scala-3. - Also updated scala-parallel-collections to latest upstream since we don't need any special handling anymore. Co-Authored-By: Nicolas Stucki <[email protected]>
This didn't work previously because scalatest dependend on an obselete version of sbt-scalajs but this isn't a problem now that we've upgrade scalatest.
Some projects rely on tag to determine the published version number, so this is needed for the community build to work properly.
Some projects rely on plugins (sbt-dynver, sbt-git) to compute a version number that includes the current git commit sha, this makes the community build really fragile since we need to hardcode the version numbers of published projects, and that number will change everytime we add a commit to a project. Moreover, `git submodule update` doesn't fetch new tags and sbt-dynver relies on the latest to set the version number, so we can end up in confusing situations where we're not publishing the version we think we're publishing. Hardcoding version numbers avoids this problem. An alternative solution would be to get the version number from the sbt project, but I don't know any good way to do that, parsing the output of `sbt "show version"` to get just the version number doesn't seem easy. I guess we could inject a new task that writes the version number to a file on disk. Revert the previous commit since we no longer need to fetch tags and so that would just slowdown the CI for no benefits.
smarter
force-pushed
the
update-scalatest-to-3.2.x-new
branch
from
2f6c469 to
364d282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.