Add support for repeatable annotations #10751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
refs: scala/scala#6846 |
|
@sjrd, will you be able to review this? |
|
Hum, probably not. I didn't notice I had been assigned, and I'm not sure why either: it's not at all my area of expertise. |
|
@liufengyun would you be available to review this? |
Yes, I can have a look. |
liufengyun
approved these changes
Mar 16, 2021
compiler/src/dotty/tools/dotc/transform/RepeatableAnnotations.scala
Outdated
Show resolved
Hide resolved
compiler/src/dotty/tools/dotc/transform/RepeatableAnnotations.scala
Outdated
Show resolved
Hide resolved
compiler/src/dotty/tools/dotc/transform/RepeatableAnnotations.scala
Outdated
Show resolved
Hide resolved
compiler/src/dotty/tools/dotc/transform/RepeatableAnnotations.scala
Outdated
Show resolved
Hide resolved
| private def transformDef(tree: DefTree)(using Context) = | ||
| val annotations = tree.symbol.annotations | ||
| if (!annotations.isEmpty) then | ||
| tree.symbol.annotations = aggregateAnnotations(tree.symbol.annotations) |
There was a problem hiding this comment.
Usually, we use SymTransformer to change symbol denotations. I think here it's fine to do so as the change is not supposed to be visible in a separately compiled module.
- now only the first clashing annotation is reported Co-authored-by: Fengyun Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5092
Before this PR, using multiple annotations of the same type on any symbol would generate incorrect bytecode; this can lead to runtime exceptions when reflection is used.
This PR makes the compiler check if they are multiple annotations of the same type and raise a compile error or aggregate them if their type supports it.