Handle help, version and @file parameters in scalac and scaladoc #11476

BarkingBad · 2021-02-19T17:50:54Z

Draft preview of changes for Arguments parser to decouple it from Dotty Context and fix three raised issues.

I know that some things can be written simplier, I will fix these on Monday morning, just want to leave it as a draft to know if these changes are generally OK.

michelou · 2021-02-21T12:17:13Z

@BarkingBad For comparison here is what kotlinc prints out :

user@host W:\dotty
$ echo %KOTLIN_HOME%
C:\opt\kotlinc-1.4.30

user@host W:\dotty
$ %KOTLIN_HOME%\bin\kotlinc.bat -help 2>&1 | tail -8
  -nowarn                    Generate no warnings
  -verbose                   Enable verbose logging output
  -version                   Display compiler version
  @<argfile>                 Read compiler arguments and file paths from the given file

Note: on Windows, arguments that contain delimiter characters (whitespace, =, ;, ,) need to be surrounded with double quotes (").

For details, see https://kotl.in/cli

BarkingBad · 2021-02-22T18:17:08Z

Help issue:

aratajczak@aratajczak:~/Dokumenty/dotty$ ./bin/scalac -help 2>&1 | head -4
Usage: scalac <options> <source files>
where possible standard options include:
-P                                                Pass an option to a plugin, e.g. -P:<plugin>:<opt>
-X                                                Print a synopsis of advanced options.
aratajczak@aratajczak:~/Dokumenty/dotty$ ./bin/scala -help 2>&1 | head -4
Usage: scala <options> <source files>
where possible standard options include:
-P                                                Pass an option to a plugin, e.g. -P:<plugin>:<opt>
-X                                                Print a synopsis of advanced options.
aratajczak@aratajczak:~/Dokumenty/dotty$ ./bin/scaladoc -help 2>&1 | head -4
Usage: scaladoc <options> <source files>
where possible standard options include:
-P                 Pass an option to a plugin, e.g. -P:<plugin>:<opt>
-bootclasspath     Override location of bootstrap class files.

Version issue:

aratajczak@aratajczak:~/Dokumenty/dotty$ ./bin/scalac -version
Scala compiler version 3.0.0-RC2-bin-SNAPSHOT-git-cd0a6da -- Copyright 2002-2021, LAMP/EPFL
aratajczak@aratajczak:~/Dokumenty/dotty$ ./bin/scala -version
Scala code runner version 3.0.0-RC2-bin-SNAPSHOT-git-cd0a6da -- Copyright 2002-2021, LAMP/EPFL
aratajczak@aratajczak:~/Dokumenty/dotty$ ./bin/scaladoc -version
Scaladoc version 3.0.0-RC2-bin-SNAPSHOT-git-cd0a6da -- Copyright 2002-2021, LAMP/EPFL

@files issue:

aratajczak@aratajczak:~/Dokumenty/dotty$ ./bin/scalac -help 2>&1| grep file
Usage: scalac <options> <source files>
-bootclasspath                                    Override location of bootstrap class files.
-classpath                                        Specify where to find user class files.
-d                                                Destination for generated classfiles.
-encoding                                         Specify character encoding used by source files.
-from-tasty                                       Compile classes from tasty files. The arguments are .tasty or .jar files.
-project-logo                                     The file that contains the project's logo (in /images).
-semanticdb-target                                Specify an alternative output directory for SemanticDB files.
-siteroot                                         A directory containing static files from which to generate documentation.
-sourcepath                                       Specify location(s) of source files.
@<file>                                           A text file containing compiler arguments (options and source files).
aratajczak@aratajczak:~/Dokumenty/dotty$ ./bin/scaladoc -help 2>&1| grep file
Usage: scaladoc <options> <source files>
-bootclasspath     Override location of bootstrap class files.
-classpath         Specify where to find user class files.
-d                 Destination for generated classfiles.
-doc-root-content  The file from which the root package documentation should be imported.
-encoding          Specify character encoding used by source files.
-project-logo      The file that contains the project's logo (in /images).
-siteroot          A directory containing static files from which to generate documentation.
-source-links      Source links provide a mapping between file in documentation and code repository.
     will match https://github.com/$organization/$repository/[blob|edit]/$revision[/$subpath]/$filePath[$lineNumber]
     will match https://gitlab.com/$organization/$repository/-/[blob|edit]/$revision[/$subpath]/$filePath[$lineNumber]
-sourcepath        Specify location(s) of source files.
@<file>            A text file containing compiler arguments (options and source files).

@michelou could you check just in case that empty package is no longer a problem for WIndows?

romanowski

Scaladoc related changes look ok

michelou · 2021-02-22T22:41:59Z

Scaladoc related changes look ok

@BarkingBad Many thanks ! Ouputs for -version, -help and scaladoc look ok for me too.

MinGW environment

Outputs for option -version :

user@host MINGW64 /w
$ echo $JAVA_HOME
/c/opt/jdk-11.0.10+9/

user@host MINGW64 /w
$ /c/opt/scala-3.0.0-RC2-bin-SNAPSHOT/bin/scala -version
Scala code runner version 3.0.0-RC2-bin-SNAPSHOT-git-ce1e2a2 -- Copyright 2002-2021, LAMP/EPFL

user@host MINGW64 /w
$ /c/opt/scala-3.0.0-RC2-bin-SNAPSHOT/bin/scalac -version
Scala compiler version 3.0.0-RC2-bin-SNAPSHOT-git-ce1e2a2 -- Copyright 2002-2021, LAMP/EPFL

user@host MINGW64 /w
$ /c/opt/scala-3.0.0-RC2-bin-SNAPSHOT/bin/scaladoc -version
Scaladoc version 3.0.0-RC2-bin-SNAPSHOT-git-ce1e2a2 -- Copyright 2002-2021, LAMP/EPFL

Outputs for option -help :

user@host MINGW64 /w
$ /c/opt/scala-3.0.0-RC2-bin-SNAPSHOT/bin/scala -help 2>&1 | head -4
Usage: scala <options> <source files>
where possible standard options include:
-P                                                Pass an option to a plugin, e.g. -P:<plugin>:<opt>
-X                                                Print a synopsis of advanced options.

user@host MINGW64 /w
$ /c/opt/scala-3.0.0-RC2-bin-SNAPSHOT/bin/scalac -help 2>&1 | head -4
Usage: scalac <options> <source files>
where possible standard options include:
-P                                                Pass an option to a plugin, e.g. -P:<plugin>:<opt>
-X                                                Print a synopsis of advanced options.

user@host MINGW64 /w
$ /c/opt/scala-3.0.0-RC2-bin-SNAPSHOT/bin/scaladoc -help 2>&1 | head -4
Usage: scaladoc <options> <source files>
where possible standard options include:
-P                 Pass an option to a plugin, e.g. -P:<plugin>:<opt>
-bootclasspath     Override location of bootstrap class files.

Scaladoc output with 2 @-files :

user@host MINGW64 /w/dotty
$ ls /c/temp/docs

user@host MINGW64 /w/dotty
$ cat scaladoc_opts?.txt
-d c:\\temp\\docs c:\\temp\\classes\\HelloWorld.tasty
-project HelloWorld

user@host MINGW64 /w/dotty
$ /c/opt/scala-3.0.0-RC2-bin-SNAPSHOT/bin/scaladoc @scaladoc_opts1.txt @scaladoc_opts2.txt

user@host MINGW64 /w/dotty
$ ls /c/temp/docs /c/temp/docs/api /c/temp/docs/api/_empty_
/c/temp/docs:
api  favicon.ico  fonts  hljs  images  scaladoc.version  scripts  styles

/c/temp/docs/api:
_empty_  index.html

/c/temp/docs/api/_empty_:
'HelloWorld$.html'

Windows environment

Outputs for option -version :

user@host W:\dotty
$ echo %JAVA_HOME%
C:\opt\jdk-11.0.10+9

user@host W:\dotty
$ c:\opt\scala-3.0.0-RC2-bin-SNAPSHOT\bin\scala -version
Scala code runner version 3.0.0-RC2-bin-SNAPSHOT-git-ce1e2a2 -- Copyright 2002-2021, LAMP/EPFL

user@host W:\dotty
$ c:\opt\scala-3.0.0-RC2-bin-SNAPSHOT\bin\scalac -version
Scala compiler version 3.0.0-RC2-bin-SNAPSHOT-git-ce1e2a2 -- Copyright 2002-2021, LAMP/EPFL

user@host W:\dotty
$ c:\opt\scala-3.0.0-RC2-bin-SNAPSHOT\bin\scaladoc -version
Scaladoc version 3.0.0-RC2-bin-SNAPSHOT-git-ce1e2a2 -- Copyright 2002-2021, LAMP/EPFL

Outputs for option -help :

user@host W:\dotty
$ c:\opt\scala-3.0.0-RC2-bin-SNAPSHOT\bin\scala -help 2>&1 | head -4
Usage: scala <options> <source files>
where possible standard options include:
-P                                                Pass an option to a plugin, e.g. -P:<plugin>:<opt>
-X                                                Print a synopsis of advanced options.

user@host W:\dotty
$ c:\opt\scala-3.0.0-RC2-bin-SNAPSHOT\bin\scalaC -help 2>&1 | head -4
Usage: scalac <options> <source files>
where possible standard options include:
-P                                                Pass an option to a plugin, e.g. -P:<plugin>:<opt>
-X                                                Print a synopsis of advanced options.

user@host W:\dotty
$ c:\opt\scala-3.0.0-RC2-bin-SNAPSHOT\bin\scaladoc -help 2>&1 | head -4
Usage: scaladoc <options> <source files>
where possible standard options include:
-P                 Pass an option to a plugin, e.g. -P:<plugin>:<opt>
-bootclasspath     Override location of bootstrap class files.

Scaladoc output with 2-files :

user@host W:\dotty
$ ls c:\temp\docs

user@host W:\dotty
$ cat scaladoc_opts?.txt
-d c:\\temp\\docs c:\\temp\\classes\\HelloWorld.tasty
-project HelloWorld

user@host W:\dotty
$ c:\opt\scala-3.0.0-RC2-bin-SNAPSHOT\bin\scaladoc @scaladoc_opts1.txt @scaladoc_opts2.txt

user@host W:\dotty
$ ls c:\temp\docs c:\temp\docs\api c:\temp\docs\api\_empty_
'c:\temp\docs':
api  favicon.ico  fonts  hljs  images  scaladoc.version  scripts  styles

'c:\temp\docs\api':
_empty_  index.html

'c:\temp\docs\api\_empty_':
'HelloWorld$.html'

smarter · 2021-02-23T15:21:52Z

compiler/test/dotty/tools/dotc/SettingsTests.scala

@@ -47,7 +47,7 @@ class SettingsTests {

    inContext {
      val args = List("-foo", "b", "-bar", "1")
-      val summary = Settings.processArguments(args, true)
+      val summary = Settings.processArguments(args, summon[Context].settingsState, true)


You can use ctx instead of summon[Context] if you import Contexts._ which contains inline def ctx(using ctx: Context): Context = ctx

Actually, it was all wrong, because we used Seq of arguments from ScalaSettings, not our custom Settings. It was working well, becuase we were inserting values on positions 0 and 1, then we were retrieving them. Nevertheless, we have to use Settings.defaultState here, but we can actually make it default value, since most of the time we won't have semi initialized state.

smarter · 2021-02-23T15:24:55Z

compiler/src/dotty/tools/dotc/Driver.scala

-      val files = fileNames.map(ctx.getFile)
-      (files, fromTastySetup(files))
+      val fileNamesOrNone = command.checkUsage(summary, sourcesRequired)(using ctx.settings)(using ctx.settingsState)
+      fileNamesOrNone.fold((None, ictx)) { fileNames =>


Not very important but we rarely use fold on Option in the compiler, instead we prefer to match on Some(...) and None

smarter · 2021-02-23T15:25:26Z

compiler/src/dotty/tools/dotc/Resident.scala

-      if (line.startsWith(quit)) ctx.reporter
-      else loop(line split "\\s+", nextCtx)
+      var (possibleFiles, ctx) = setup(args, prevCtx)
+      if possibleFiles.isDefined then


I would pattern match on possibleFiles here instead of using isDefined/get

smarter · 2021-02-23T15:26:58Z

compiler/src/dotty/tools/dotc/config/CompilerCommand.scala

-  override def versionMsg: String = s"Scala compiler $versionString -- $copyrightString"
-  override def ifErrorsMsg: String = "  scalac -help  gives more information"
+abstract class CompilerCommand extends CliCommand:
+  final type ConcreteSettings = ScalaSettings


I don't think final on a type alias does anything.

smarter · 2021-02-23T15:30:11Z

compiler/src/dotty/tools/dotc/Driver.scala

-  def setup(args: Array[String], rootCtx: Context): (List[AbstractFile], Context) = {
+  protected def command: CompilerCommand = ScalacCommand
+
+  def setup(args: Array[String], rootCtx: Context): (Option[List[AbstractFile]], Context) = {


An Option of a List is weird, the documentation of this method should explain clearly how None differs from Some(Nil) here.

Will update documentation

michelou · 2021-02-24T10:04:51Z

@BarkingBad
Here is another use case to be fixed : user-friendly error message when @-file doesn't exist.

Java behavior

user@host MINGW64 /w/dotty
$ echo $JAVA_HOME
/c/opt/jdk-11.0.10+9/

user@host MINGW64 /w/dotty
$ /c/opt/jdk-11.0.10+9/bin/javac @dummy.txt
error: file not found: dummy.txt

Scala 3 behavior

user@host MINGW64 /w/dotty
$ /c/opt/scala-3.0.0-RC2-bin-SNAPSHOT/bin/scaladoc @dummy.txt
java.io.FileNotFoundException: argument file dummy.txt could not be found
        at dotty.tools.dotc.config.CliCommand.expandArg$1(CliCommand.scala:52)
        at dotty.tools.dotc.config.CliCommand.expandedArguments$2$$anonfun$1(CliCommand.scala:61)
        at scala.collection.immutable.List.flatMap(List.scala:293)
        at dotty.tools.dotc.config.CliCommand.expandedArguments$1(CliCommand.scala:62)
        at dotty.tools.dotc.config.CliCommand.distill(CliCommand.scala:65)
        at dotty.tools.dotc.config.CliCommand.distill$(CliCommand.scala:12)
        at dotty.tools.scaladoc.ScaladocCommand$.distill(ScaladocCommand.scala:19)
        at dotty.tools.scaladoc.Scaladoc$.extract(Scaladoc.scala:79)
        at dotty.tools.scaladoc.Scaladoc$.run(Scaladoc.scala:49)
        at dotty.tools.scaladoc.Main.run(Main.scala:18)
        at dotty.tools.scaladoc.Main$.main(Main.scala:24)
        at dotty.tools.scaladoc.Main.main(Main.scala)

user@host MINGW64 /w/dotty
$ /c/opt/scala-3.0.0-RC2-bin-SNAPSHOT/bin/scalac @dummy.txt
Exception in thread "main" java.io.FileNotFoundException: argument file dummy.txt could not be found
        at dotty.tools.dotc.config.CliCommand.expandArg$1(CliCommand.scala:52)
        at dotty.tools.dotc.config.CliCommand.expandedArguments$2$$anonfun$1(CliCommand.scala:61)
        at scala.collection.immutable.List.flatMap(List.scala:293)
        at dotty.tools.dotc.config.CliCommand.expandedArguments$1(CliCommand.scala:62)
        at dotty.tools.dotc.config.CliCommand.distill(CliCommand.scala:65)
        at dotty.tools.dotc.config.CliCommand.distill$(CliCommand.scala:12)
        at dotty.tools.dotc.config.CompilerCommand.distill(CompilerCommand.scala:12)
        at dotty.tools.dotc.Driver.setup(Driver.scala:79)
        at dotty.tools.dotc.Driver.process(Driver.scala:199)
        at dotty.tools.dotc.Driver.process(Driver.scala:169)
        at dotty.tools.dotc.Driver.process(Driver.scala:181)
        at dotty.tools.dotc.Driver.main(Driver.scala:210)
        at dotty.tools.dotc.Main.main(Main.scala)

Scala 2 behavior

user@host MINGW64 /w/dotty
$ /c/opt/scala-2.13.5/bin/scaladoc @dummy.txt
Exception in thread "main" java.io.FileNotFoundException: argument file dummy.txt could not be found
        at scala.tools.nsc.CompilerCommand.expandArg(CompilerCommand.scala:132)
        at scala.tools.nsc.CompilerCommand.$anonfun$processArguments$1(CompilerCommand.scala:142)
        at scala.tools.nsc.CompilerCommand.processArguments(CompilerCommand.scala:141)
        at scala.tools.nsc.CompilerCommand.<init>(CompilerCommand.scala:23)
        at scala.tools.nsc.ScalaDoc$Command.<init>(ScalaDoc.scala:89)
        at scala.tools.nsc.ScalaDoc.process(ScalaDoc.scala:32)
        at scala.tools.nsc.ScalaDoc$.main(ScalaDoc.scala:99)
        at scala.tools.nsc.ScalaDoc.main(ScalaDoc.scala)

user@host MINGW64 /w/dotty
$ /c/opt/scala-2.13.5/bin/scalac @dummy.txt
Exception in thread "main" java.io.FileNotFoundException: argument file dummy.txt could not be found
        at scala.tools.nsc.CompilerCommand.expandArg(CompilerCommand.scala:132)
        at scala.tools.nsc.CompilerCommand.$anonfun$processArguments$1(CompilerCommand.scala:142)
        at scala.tools.nsc.CompilerCommand.processArguments(CompilerCommand.scala:141)
        at scala.tools.nsc.CompilerCommand.<init>(CompilerCommand.scala:23)
        at scala.tools.nsc.Driver.process(Driver.scala:56)
        at scala.tools.nsc.Driver.main(Driver.scala:82)
        at scala.tools.nsc.Main.main(Main.scala)

smarter · 2021-02-24T12:57:46Z

compiler/src/dotty/tools/dotc/Driver.scala

+   *  would change the default behaviour of the compiler.
+   *
+   *  @return A tuple of Option of List and Context.
+   *  If there is no setting preventing us from continuing compilation, function returns Some(List)


This a method, not a function:

Suggested change

* If there is no setting preventing us from continuing compilation, function returns Some(List)

* If there is no setting like `-help` preventing us from continuing compilation, this method returns Some(...)

smarter · 2021-02-24T12:59:40Z

compiler/src/dotty/tools/dotc/Driver.scala

+   *  @return A tuple of Option of List and Context.
+   *  If there is no setting preventing us from continuing compilation, function returns Some(List)
+   *  and Context updated respectively with compilation files. In particular, it can be Some(Nil).
+   *  If compilation should be interruped, function returns None and an old Context.


Suggested change

* If compilation should be interruped, function returns None and an old Context.

* If compilation should be interrupted, this method returns None and an old Context.

But if you're returning the original Context, then there's no point in returning it at all and you could change the result type of this method to Option[(List[AbstractFile], Context)]

Good point, will change

BarkingBad · 2021-02-24T18:08:04Z

@michelou I have changed the error handling, instead of throwing an exception I used context reporter to report an error, however, it does not break the execution by default (with no fatal warnings etc.) and continue as if the file was empty. Should I change it to always stop if there is problem with file, or an error is sufficient?

smarter · 2021-02-24T18:04:26Z

compiler/src/dotty/tools/dotc/Driver.scala

+  /** Setup context with initialized settings from CLI arguments, then check if there are any settings that
+   *  would change the default behaviour of the compiler.
+   *
+   *  @return An Option of tuple of List and Context.


That line isn't really necessary since it just repeats the type without adding information.

smarter · 2021-02-24T18:04:43Z

compiler/src/dotty/tools/dotc/Driver.scala

+   *
+   *  @return An Option of tuple of List and Context.
+   *  If there is no setting like `-help` preventing us from continuing compilation, this method returns
+   *  Some of files to compile and updated Context.


Suggested change

* Some of files to compile and updated Context.

* a list of files to compile and an updated Context.

smarter · 2021-02-24T18:05:52Z

compiler/src/dotty/tools/dotc/decompiler/IDEDecompilerDriver.scala

@@ -19,7 +19,9 @@ class IDEDecompilerDriver(val settings: List[String]) extends dotc.Driver {
    val rootCtx = initCtx.fresh.addMode(Mode.Interactive | Mode.ReadPositions | Mode.ReadComments)
    rootCtx.setSetting(rootCtx.settings.YretainTrees, true)
    rootCtx.setSetting(rootCtx.settings.fromTasty, true)
-    val ctx = setup(settings.toArray :+ "dummy.scala", rootCtx)._2
+    val ctx = setup(settings.toArray :+ "dummy.scala", rootCtx) match


We should never be passing --help here or another flag that interrupts compilation so you could just do .get on the result of setup.

Will change

smarter · 2021-02-24T18:06:18Z

staging/src/scala/quoted/staging/QuoteDriver.scala

@@ -33,7 +33,10 @@ private class QuoteDriver(appClassloader: ClassLoader) extends Driver:
          new VirtualDirectory("<quote compilation output>")
    end outDir

-    val (_, ctx0: Context) = setup(settings.compilerArgs.toArray :+ "dummy.scala", initCtx.fresh)
+    val freshContext = initCtx.fresh
+    val ctx0 = setup(settings.compilerArgs.toArray :+ "dummy.scala", freshContext) match


Same comment as in IDEDecompilingDriver

Will change

smarter · 2021-02-24T18:07:27Z

compiler/src/dotty/tools/repl/ReplDriver.scala

+   * Possible reason for unsuccessful run are raised flags in CLI like --help or --version
+   */
+  final def tryRunning = if shouldStart then
+    println("Starting scala3 REPL...")


I see this was here before, but I would just delete that line, the repl already prints enough stuff when it starts.

michelou · 2021-02-25T11:58:17Z

@BarkingBad Here's what I get now (after your force-pushed). The error message is followed by the help message (that's ok for me since my priority was to get rid of FileNotFoundException).

user@host MINGW64 /w/dotty
$ /c/opt/scala-3.0.0-RC2-bin-SNAPSHOT/bin/scaladoc @dummy.txt 2>&1 | head -8
Argument file dummy.txt could not be found
Usage: scaladoc <options> <source files>
where possible standard options include:
-P                 Pass an option to a plugin, e.g. -P:<plugin>:<opt>
-bootclasspath     Override location of bootstrap class files.
-classpath         Specify where to find user class files.
                   Default: ..
-color             Colored output

user@host MINGW64 /w/dotty
$ /c/opt/scala-3.0.0-RC2-bin-SNAPSHOT/bin/scaladoc @dummy.txt 2>&1 | head -7
Argument file dummy.txt could not be found
Usage: scaladoc <options> <source files>
where possible standard options include:
-P                 Pass an option to a plugin, e.g. -P:<plugin>:<opt>
-bootclasspath     Override location of bootstrap class files.
-classpath         Specify where to find user class files.
                   Default: ..

BarkingBad · 2021-02-25T14:06:31Z

The help message pops up because incorrect path makes @file argument transparent, and since there is no other parameter provided we assume it was run with no parameters and show help message. I can fix it if it is still a concern

BarkingBad requested review from nicolasstucki and romanowski February 19, 2021 17:50

This was linked to issues Feb 19, 2021

Command line tools : option "-version" #11452

Closed

Command line tools : option "-help" #11453

Closed

scaladoc tool : argument files (@-files) #11454

Closed

BarkingBad force-pushed the scala3doc/cli-fixes branch from ce13b5e to 8603bac Compare February 19, 2021 18:09

This was referenced Feb 20, 2021

Command line tools : option "-version" #11452

Closed

scaladoc tool : argument files (@-files) #11454

Closed

BarkingBad marked this pull request as ready for review February 22, 2021 18:10

romanowski previously approved these changes Feb 22, 2021

View reviewed changes

romanowski requested a review from smarter February 22, 2021 20:57

BarkingBad added 2 commits February 23, 2021 09:53

Handle help, version and @file parameters in scalac and scaladoc

a69b565

Refactor CliCommand, Scaladoc arguments parsing and add some tests

25aa624

BarkingBad dismissed romanowski’s stale review via 7e69e2d February 23, 2021 09:29

BarkingBad force-pushed the scala3doc/cli-fixes branch from cd0a6da to 7e69e2d Compare February 23, 2021 09:29

BarkingBad requested a review from romanowski February 23, 2021 10:09

smarter requested changes Feb 23, 2021

View reviewed changes

BarkingBad force-pushed the scala3doc/cli-fixes branch from 7e69e2d to b79bc84 Compare February 24, 2021 08:43

BarkingBad requested a review from smarter February 24, 2021 08:43

smarter requested changes Feb 24, 2021

View reviewed changes

BarkingBad force-pushed the scala3doc/cli-fixes branch 2 times, most recently from e5a54cd to 56d3e56 Compare February 24, 2021 18:00

BarkingBad requested a review from smarter February 24, 2021 18:00

smarter approved these changes Feb 24, 2021

View reviewed changes

Fix problem with badly initialized context

c4c63fc

BarkingBad force-pushed the scala3doc/cli-fixes branch from 56d3e56 to c4c63fc Compare February 24, 2021 18:26

BarkingBad merged commit 58c77c3 into scala:master Feb 25, 2021

BarkingBad deleted the scala3doc/cli-fixes branch February 25, 2021 14:03

Kordyjan added this to the 3.0.0 milestone Aug 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle help, version and @file parameters in scalac and scaladoc #11476

Handle help, version and @file parameters in scalac and scaladoc #11476

BarkingBad commented Feb 19, 2021

michelou commented Feb 21, 2021

BarkingBad commented Feb 22, 2021

romanowski left a comment

michelou commented Feb 22, 2021 •

edited

Loading

smarter Feb 23, 2021

BarkingBad Feb 24, 2021

smarter Feb 23, 2021

BarkingBad Feb 24, 2021

smarter Feb 23, 2021

BarkingBad Feb 24, 2021

smarter Feb 23, 2021

BarkingBad Feb 24, 2021

smarter Feb 23, 2021

BarkingBad Feb 24, 2021

michelou commented Feb 24, 2021 •

edited

Loading

smarter Feb 24, 2021

BarkingBad Feb 24, 2021

smarter Feb 24, 2021

BarkingBad Feb 24, 2021

BarkingBad commented Feb 24, 2021

smarter Feb 24, 2021

smarter Feb 24, 2021

smarter Feb 24, 2021

BarkingBad Feb 24, 2021

smarter Feb 24, 2021

BarkingBad Feb 24, 2021

smarter Feb 24, 2021

BarkingBad Feb 24, 2021

michelou commented Feb 25, 2021

BarkingBad commented Feb 25, 2021

	* If there is no setting preventing us from continuing compilation, function returns Some(List)
	* If there is no setting like `-help` preventing us from continuing compilation, this method returns Some(...)

	* If compilation should be interruped, function returns None and an old Context.
	* If compilation should be interrupted, this method returns None and an old Context.

	* Some of files to compile and updated Context.
	* a list of files to compile and an updated Context.

Handle help, version and @file parameters in scalac and scaladoc #11476

Handle help, version and @file parameters in scalac and scaladoc #11476

Conversation

BarkingBad commented Feb 19, 2021

michelou commented Feb 21, 2021

BarkingBad commented Feb 22, 2021

romanowski left a comment

Choose a reason for hiding this comment

michelou commented Feb 22, 2021 • edited Loading

MinGW environment

Windows environment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michelou commented Feb 24, 2021 • edited Loading

Java behavior

Scala 3 behavior

Scala 2 behavior

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BarkingBad commented Feb 24, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michelou commented Feb 25, 2021

BarkingBad commented Feb 25, 2021

michelou commented Feb 22, 2021 •

edited

Loading

michelou commented Feb 24, 2021 •

edited

Loading