Survive duplicated symbols generated by 2.13 #11991
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure what goes on here. Scala 2.13 generating duplicate symbols in some cases (seemingly related to type lambda encodings) looks like a bug. This PR simply avoids the assertion violation by not entering the second symbol. I guess we need more experience to find out whether that works in all cases. |
|
I've verified that in the case of i11173, Scala 2 pickled the exact same type parameter symbol twice, so picking one or the other is fine. I've opened #12120 which goes a bit further than this PR and skips unpickling a type parameter which is already present, I've also fixed the test to actually test the Scala2Unpickler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11173
Fixes #11984 (probably)