-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ASM library #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASM library #12
Conversation
Same code as [1], but `dotty.tools.asm` namespace. [1] scala/scala@df4df0a
the only part of scala.tools.asm to maintain manually. same commit as scala/scala@f994343
Same commit as scala/scala@f9053e5
same commit as scala/scala@b50e6b4
same commit as scala/scala@22ee2df
I would suggest considering the approach we're planning to implement in Scala 2.12. It'll be some variation on https://github.com/adriaanm/scala/compare/asm5. |
One downside (and a reason I didn't push for it) is that the shading as implemented there rewrites the whole scala-compiler jar (so that we don't have a separate asm jar). I think it would be better to have a scala-asm artifact that the compiler can depend on explicitly. |
Right, I thought about the other options. I think doing the same thing as |
@lrytz why not merge this PR into the |
OK for me, I'll create a new PR then |
doc(givens): mention thread safety
Backport "fix `dotty.tools.dotc.config.Properties` scaladoc" to LTS
ASM library.
Source code is taken from https://github.com/scala/scala/tree/master/src/asm, the package name is changed from
scala.tools.asm
todotty.tools.asm
.The commits reflect the evolution of the ASM source code in scala/scala.
Review by @magarciaEPFL