Skip to content

ASM library #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

ASM library #12

wants to merge 9 commits into from

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Feb 12, 2014

ASM library.

Source code is taken from https://github.com/scala/scala/tree/master/src/asm, the package name is changed from scala.tools.asm to dotty.tools.asm.

The commits reflect the evolution of the ASM source code in scala/scala.

Review by @magarciaEPFL

@adriaanm
Copy link
Contributor

I would suggest considering the approach we're planning to implement in Scala 2.12. It'll be some variation on https://github.com/adriaanm/scala/compare/asm5.

@adriaanm
Copy link
Contributor

One downside (and a reason I didn't push for it) is that the shading as implemented there rewrites the whole scala-compiler jar (so that we don't have a separate asm jar). I think it would be better to have a scala-asm artifact that the compiler can depend on explicitly.

@lrytz
Copy link
Member Author

lrytz commented Feb 13, 2014

Right, I thought about the other options. I think doing the same thing as scalac simplifies things. It will be easy to port any changes over to dotc.

@magarciaEPFL
Copy link

@lrytz why not merge this PR into the backend branch first, as we've been doing so far? Doing so will later allow us to distill a cleaner history for merging into master. Other than that, looks good.

@lrytz
Copy link
Member Author

lrytz commented Feb 13, 2014

OK for me, I'll create a new PR then

@lrytz lrytz closed this Feb 13, 2014
@lrytz lrytz mentioned this pull request Feb 13, 2014
smarter pushed a commit that referenced this pull request Mar 12, 2020
doc(givens): mention thread safety
pikinier20 pushed a commit that referenced this pull request Aug 16, 2022
szymon-rd pushed a commit that referenced this pull request Dec 9, 2022
WojciechMazur added a commit to WojciechMazur/dotty that referenced this pull request Mar 19, 2025
Backport "fix `dotty.tools.dotc.config.Properties` scaladoc" to LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants