Support inline val references in top level splices #12235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japgolly
reviewed
Apr 28, 2021
| @@ -242,6 +243,11 @@ object Splicer { | |||
| case Literal(Constant(value)) => | |||
| interpretLiteral(value) | |||
|
|
|||
| case tree: Ident if tree.symbol.is(Inline, butNot = Method) => | |||
| tree.tpe.widenTermRefExpr match | |||
| case ConstantType(c) => c.value.asInstanceOf[Object] | |||
There was a problem hiding this comment.
We should probably handle null here too
There was a problem hiding this comment.
We do not support inline val n = null. That should be added when we add support for it and can write a test case for that logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12196