Skip to content

Split out docs for scala.compiletime from docs for inline #12238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2021

Conversation

MaximeKjaer
Copy link
Contributor

inline and scala.compiletime are two separate topics, so I think it makes sense to have two separate pages for them. It also makes it easier to find the compile-time ops in the sidebar.

@nicolasstucki nicolasstucki self-assigned this Apr 27, 2021
@MaximeKjaer MaximeKjaer enabled auto-merge April 27, 2021 11:41
@b-studios
Copy link
Contributor

@MaximeKjaer could you maybe double check that references from docs.scala-lang.org are still valid after this change? I am in particular thinking about the ones in https://docs.scala-lang.org/scala3/guides/macros/

@MaximeKjaer MaximeKjaer disabled auto-merge April 27, 2021 13:32
@MaximeKjaer
Copy link
Contributor Author

@b-studios That's a good point, thank you. I checked, the only references to the inline page are in SIP minutes mentioning inline, so all references should still be valid.

@MaximeKjaer MaximeKjaer enabled auto-merge April 27, 2021 13:56
@MaximeKjaer MaximeKjaer merged commit 3d8b6a1 into scala:master Apr 27, 2021
@MaximeKjaer MaximeKjaer deleted the split-inline-docs branch April 27, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants