Skip to content

Cleanup scaladoc quotes #12324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 6, 2021

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented May 4, 2021

Partially remove Quotes context from fields.

Follow API design of https://docs.scala-lang.org/scala3/guides/macros/reflection.html#macro-api-design

@nicolasstucki nicolasstucki self-assigned this May 4, 2021
@nicolasstucki nicolasstucki force-pushed the clenup-scaladoc-quotes branch from e0b7a9e to 805317b Compare May 4, 2021 17:50
@nicolasstucki nicolasstucki force-pushed the clenup-scaladoc-quotes branch from 805317b to eeec213 Compare May 4, 2021 17:53
@nicolasstucki nicolasstucki force-pushed the clenup-scaladoc-quotes branch from 5f340d1 to 69fa64c Compare May 4, 2021 22:03
@nicolasstucki nicolasstucki force-pushed the clenup-scaladoc-quotes branch from 69fa64c to 0b0fafd Compare May 4, 2021 22:03
@nicolasstucki nicolasstucki marked this pull request as ready for review May 5, 2021 07:34
@nicolasstucki nicolasstucki requested a review from abgruszecki May 5, 2021 07:36
@nicolasstucki nicolasstucki requested a review from romanowski May 5, 2021 07:36
Copy link
Contributor

@abgruszecki abgruszecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I took a look at the generated docs and everything seemed to look OK.

@nicolasstucki nicolasstucki removed the request for review from romanowski May 6, 2021 12:17
@nicolasstucki nicolasstucki merged commit dfcc26a into scala:master May 6, 2021
@nicolasstucki nicolasstucki deleted the clenup-scaladoc-quotes branch May 6, 2021 12:17
@Kordyjan Kordyjan added this to the 3.0.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants