Scaladoc: Handle types that were throwing match errors #12553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanowski
reviewed
May 21, 2021
| case e: AssertionError => texts("LazyRef(...)") | ||
| } | ||
|
|
||
| case tpe => throw MatchError(tpe.show(using Printer.TypeReprStructure)) |
There was a problem hiding this comment.
I think we should more verbose message that this is a bug and one needs to report it
pikinier20
force-pushed
the
scaladoc/match-errors-fix
branch
from
4a8e1d0 to
63ee9c5
Compare
BarkingBad
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12327