processArgs is final for some tailrec #12589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long lists of compiler args are not unusual, so avoid running out of stack.
smarter
approved these changes
May 26, 2021
There was a problem hiding this comment.
Nice improvements, thanks! By the way, if you feel like doing more work on our settings infrastructure, I recently discovered that SettingsState#update would either mutate or not mutate the original SettingsState depending on whether a setitng value had been read from it previously or not. This is awful design and makes it impossible to rely on it (#11582 (comment)), so it'd be great if we could replace that by something less weird like simply using an immutable HashMap for settings (or port whatever Scala 2 uses nowadays).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12588