Skip to content

Fix dead links for docs and add simple test for sourcelinks #12622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/docs/contributing/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,6 @@ Before contributing to Dotty, we invite you to consult the
Community
-------------
The main development discussion channels are:
- [github.com/lampepfl/dotty/discussions](github.com/lampepfl/dotty/discussions)
- [contributors.scala-lang.org](contributors.scala-lang.org)
- [gitter.im/scala/contributors](gitter.im/scala/contributors)
- [github.com/lampepfl/dotty/discussions](https://github.com/lampepfl/dotty/discussions)
- [contributors.scala-lang.org](https://contributors.scala-lang.org)
- [gitter.im/scala/contributors](https://gitter.im/scala/contributors)
2 changes: 1 addition & 1 deletion docs/docs/internals/syntax.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ type val var while with yield
as derives end extension infix inline opaque open transparent using | * + -
```

See the [separate section on soft keywords](./soft-modifier.md) for additional
See the [separate section on soft keywords](../reference/soft-modifier.md) for additional
details on where a soft keyword is recognized.

## Context-free Syntax
Expand Down
3 changes: 2 additions & 1 deletion project/Build.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1350,7 +1350,8 @@ object Build {
"-comment-syntax", "wiki",
"-siteroot", "docs",
s"-source-links:docs=github://lampepfl/dotty/master#docs",
"-doc-root-content", docRootFile.toString
"-doc-root-content", docRootFile.toString,
"-Ydocument-synthetic-types"
)
))
}.evaluated,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ class RemoteLinksTest:
def scala3SourceLink =
assertTrue(mtslAll.find((k, _) => k == "PolyFunction").isDefined) // source link to Scala3 stdlib class

@Test
def tastySourceLink =
assertTrue(mtslAll.find((k, _) => k == "TastyBuffer").isDefined) // source link to Scala3 tasty class

@Test
def runTest =
assertTrue(mtslAll.nonEmpty)
Expand Down