Scaladoc: Add scaladoc binary test #12789
Conversation
project/scripts/cmdTests
Outdated
| "-skip-by-id:scala.runtime.MatchCase" \ | ||
| -project-footer "Copyright (c) 2002-2021, LAMP/EPFL" \ | ||
| -author -groups -revision master -project-version 3.0.2-RC1-bin-SNAPSHOT \ | ||
| /Users/fzybala/dotty/out/bootstrap/scaladoc-testcases/scala-3.0.2-RC1-bin-SNAPSHOT-nonbootstrapped/classes 2>&1 || echo "generated testcases project with scripts" |
There was a problem hiding this comment.
/Users/fzybala/dotty looks strange
There was a problem hiding this comment.
Yes, I've missed that
| @@ -9,7 +9,7 @@ trait Quotes2[A] { | |||
| /** | |||
| * SNIPPET(OUTERLINEOFFSET:13,OUTERCOLUMNOFFSET:10,INNERLINEOFFSET:6,INNERCOLUMNOFFSET:6) | |||
| * ERROR(LINE:13,COLUMN:12) | |||
| * ```scala sc:compile | |||
There was a problem hiding this comment.
Why do we need to change that script to fail?
There was a problem hiding this comment.
It's because the snippets that I've fixed, had wrong flags and were throwing errors on documentation generation. It caused the process to exit with failure and break the script execution
pikinier20
force-pushed
the
scaladoc-script-tests
branch
from
a2856c9 to
065db77
Compare
project/Build.scala
Outdated
| 0 | ||
| } catch { | ||
| case _ : Throwable => 1 |
There was a problem hiding this comment.
Do you actually need to return 0 or 1 here instead of letting it throw an exception if it fails?
There was a problem hiding this comment.
Tbh it's the way it was when we ran part of tasks using script and the rest using runMain. Integer return type was there for compatibility between these two approaches but now it can be removed
pikinier20
force-pushed
the
scaladoc-script-tests
branch
from
065db77 to
2ae2f64
Compare
| @@ -1265,20 +1265,10 @@ object Build { | |||
| s"-source-links:github://lampepfl/dotty/$referenceVersion", | |||
| ) ++ scalacOptionsDocSettings ++ revision ++ params ++ targets | |||
| import _root_.scala.sys.process._ | |||
Ordered members by name due to indeterministic order of members coming from TASTY.