Skip to content

Properly handle self-types in reflection member lookup #12893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2483,15 +2483,22 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler

def declaredFields: List[Symbol] = self.unforcedDecls.filter(isField)

/** The prefix on which a member lookup should be performed. */
private def lookupPrefix: TypeRepr =
if self.isClass then
self.thisType // Needed to handle self-types (as in tests/run-macros/self)
else
self.namedType

def memberField(name: String): Symbol = fieldMember(name)
def fieldMember(name: String): Symbol =
appliedTypeRef(self).allMembers.iterator.map(_.symbol).find {
lookupPrefix.allMembers.iterator.map(_.symbol).find {
sym => isField(sym) && sym.name.toString == name
}.getOrElse(dotc.core.Symbols.NoSymbol)

def memberFields: List[Symbol] = fieldMembers
def fieldMembers: List[Symbol] =
appliedTypeRef(self).allMembers.iterator.map(_.symbol).collect {
lookupPrefix.allMembers.iterator.map(_.symbol).collect {
case sym if isField(sym) => sym.asTerm
}.toList

Expand All @@ -2507,13 +2514,13 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler

def memberMethod(name: String): List[Symbol] = methodMember(name)
def methodMember(name: String): List[Symbol] =
appliedTypeRef(self).allMembers.iterator.map(_.symbol).collect {
lookupPrefix.allMembers.iterator.map(_.symbol).collect {
case sym if isMethod(sym) && sym.name.toString == name => sym.asTerm
}.toList

def memberMethods: List[Symbol] = methodMembers
def methodMembers: List[Symbol] =
appliedTypeRef(self).allMembers.iterator.map(_.symbol).collect {
lookupPrefix.allMembers.iterator.map(_.symbol).collect {
case sym if isMethod(sym) => sym.asTerm
}.toList

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,13 @@ object SyntheticsSupport:
import dotty.tools.dotc
given ctx: dotc.core.Contexts.Context = quotes.asInstanceOf[scala.quoted.runtime.impl.QuotesImpl].ctx
val sym = rsym.asInstanceOf[dotc.core.Symbols.Symbol]
sym.typeRef.appliedTo(sym.typeParams.map(_.typeRef)).allMembers.iterator.map(_.symbol)
// `lookupPrefix` is private in `QuotesImpl#SymbolMethods`
val lookupPrefix =
if sym.isClass then
sym.thisType
else
sym.namedType
lookupPrefix.allMembers.iterator.map(_.symbol)
.collect {
case sym if
(!sym.is(dotc.core.Flags.ModuleVal) || sym.is(dotc.core.Flags.Given)) &&
Expand Down
3 changes: 3 additions & 0 deletions tests/run-macros/self.check
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
ExprType(TypeRef(TermRef(ThisType(TypeRef(NoPrefix,module class <root>)),object scala),Int))
MethodType(List(x), List(TypeRef(TermRef(TermRef(ThisType(TypeRef(NoPrefix,module class <root>)),object scala),Predef),String)), TypeRef(TypeRef(ThisType(TypeRef(ThisType(TypeRef(NoPrefix,module class <root>)),module class <empty>)),B),X))
MethodType(List(x), List(TypeRef(TermRef(ThisType(TypeRef(NoPrefix,module class <root>)),object scala),Int)), TypeRef(TypeRef(ThisType(TypeRef(ThisType(TypeRef(NoPrefix,module class <root>)),module class <empty>)),B),X))
35 changes: 35 additions & 0 deletions tests/run-macros/self/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import scala.quoted.*

trait A {
type X
}
trait B { self: A =>
def foo(x: Int): X
def foo(x: String): X
}

object Obj {
def foo: Int = 1
}

object Macros {

inline def test(): String = ${ testImpl }

private def testImpl(using Quotes) : Expr[String] = {
import quotes.reflect.*
val bTpe = TypeRepr.of[B]
val bSym = bTpe.classSymbol.get
val bMethSyms = bSym.methodMember("foo") // Used to throw a MissingType exception
val bMethTpes = bMethSyms.map(bTpe.memberType)

// Make sure we didn't break member lookup on terms
val objTpe = TypeRepr.of[Obj.type]
val objSym = objTpe.termSymbol
val objMethSyms = objSym.methodMember("foo")
val objMethTpes = objMethSyms.map(objTpe.memberType)

Expr((objMethTpes ++ bMethTpes).map(_.toString).sorted.mkString("\n"))
}

}
8 changes: 8 additions & 0 deletions tests/run-macros/self/Test_2.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@

object Test {

def main(args: Array[String]): Unit = {
println(Macros.test())
}

}