Skip to content

Various static site fixes #12993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2021
Merged

Conversation

BarkingBad
Copy link
Contributor

@BarkingBad BarkingBad commented Jul 1, 2021

There are some changes in the behaviour so the docs have to be updated both at dotty.epfl.ch and scalalang.org

@BarkingBad BarkingBad force-pushed the scaladoc/site-fixes branch from 093ae71 to eff40e5 Compare July 1, 2021 12:31
Copy link
Contributor

@vincenzobaz vincenzobaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the codebase but the changes seem reasonable 😄

private def getAllPages: Seq[Page] =

def traversePages(page: Page): (Page, Seq[Page]) =
val (newChildren, newPagesToRemove): (Seq[Page], Seq[Page]) = page.children.map(traversePages(_)).foldLeft((Seq[Page](), Seq[Page]())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Seq[Page], Seq[Page]) can be turned into a case class to make things much easier

@romanowski romanowski merged commit 6cc1ee1 into scala:master Jul 2, 2021
@Kordyjan Kordyjan added this to the 3.0.2 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants