Crash when calling Compiler.newRun() without a docCtx

[GavinRay97]

Changes based on suggestion in the issue:

• java.util.NoSuchElementException: None.get when using Compiler.newRun() during ContextBase.initialize() #12998 (comment)

And the implementation currently seen here:
https://github.com/lampepfl/dotty/blob/79fae194b80e136a243e7c7f949268166d169e1e/compiler/src/dotty/tools/dotc/typer/Namer.scala#L449

[som-snytt]

You'll want to squash and force push one clean commit. But the change looks idiomatic.

It would be nice if the docCtx.get in TreePickler were idiomatic so grep doesn't notice it; that follows an assert. There is a getOrElse throw in QuotesImpl.

[smarter]

It looks like you haven't signed the CLA yet, would you mind doing so at https://www.lightbend.com/contribute/cla/scala ?

[GavinRay97]

Apologies for the delay, have signed the CLA.

Somewhat embarrassingly, though I use git every day for years, I'm not well-versed beyond basic checkout/commit/pull/branch/push.

To squash and force-push as a single commit, would be something like this?

$ git rebase -i HEAD~2 # Interactive rebase last 2 commits on local
# Select "Squash" from prompt
$ git commit
$ git push -f

Or

$ git reset --soft HEAD~2 && git commit
$ git push -f

[smarter]

There's multiple ways to do it, if you squash using git rebase -i, it will prompt you for the commit message of the squashed commit and generate it itself, so you don't need to git commit afterwards, but you'll indeed need to do git push -f.

[GavinRay97]

Okay I think I managed to get it sorted out. Let me know if it's still not right and we can give this a go again 😅

[smarter]

It looks good but to have the issue be automatically closed when this PR is merged, you need to include "Fixes #12988" somewhere in the body of the commit message (also this is nitpicking but ideally the first line of the commit message would be a bit more descriptive of what is being fixed e.g., "Fix crash when calling Compiler.newRun() without a docCtx")

[smarter]

By the way, you can edit just the commit message by doing git commit --amend (and then git push -f again)

[GavinRay97]

By the way, you can edit just the commit message by doing git commit --amend (and then git push -f again)

Thank you for this, I didn't know this and this definitely helps a lot.
Gimme two seconds, commit incoming =)

[smarter]

LGTM, thank you!