[backport] Fix separate compilation issues with opaque types #13219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how to proceed here. Can someone else take over? If not this will have to wait for next release. |
|
Linked to #13196 maybe? Do we have to backport that first? |
|
Maybe somebody else can take this over (assuming we really want to backport)? |
|
@BarkingBad it looks like the stdlib-sourcelinks-test test is broken in the release-3.0.2 branch, could you investigate? |
|
Hopefully, #13274 will fix the problem. |
Customized printer instead of falling back to toString
Type parameter Ax needs to be declared explicitly as covariant since Tensor is opaque. This fell through the cracks before since under separate compilation type parameters of opaque types got assigned structural variances. But this is incorrect. Under joint compilation there would be an error.
smarter
force-pushed
the
fix-13190-backport
branch
from
941f2e3 to
84c2b11
Compare
smarter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #13206